Highlight error after upgrade in php files

Bug #1242387 reported by Pablo M. Rivas
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bluefish
Fix Released
Medium
bluefish (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

After upgrade to ubuntu 13.10 there is an error in highlighting of php files.
One line comments don't close automatcally after a new line.

Happened on two systems upgraded from 13.04 to 13.10
Tryed download and compiling from source (bluefish 2-2.4 and 2-2.3) with no luck.
Tryed apt-get purge bluefish and apt-get install bluefish with no luck

Changing language mode to perl or javascript the highlight works correct (but lost auto-completion).

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: bluefish 2.2.4-2
ProcVersionSignature: Ubuntu 3.8.0-30.44-generic 3.8.13.6
Uname: Linux 3.8.0-30-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.12.5-0ubuntu2
Architecture: amd64
Date: Sun Oct 20 13:36:31 2013
InstallationDate: Installed on 2013-05-28 (145 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424)
MarkForUpload: True
SourcePackage: bluefish
UpgradeStatus: Upgraded to saucy on 2013-10-19 (0 days ago)

Revision history for this message
Pablo M. Rivas (pmrivas) wrote :
Revision history for this message
Pablo M. Rivas (pmrivas) wrote :

Filled bug in bugzilla.gnome.org : https://bugzilla.gnome.org/show_bug.cgi?id=704108

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in bluefish (Ubuntu):
status: New → Confirmed
Revision history for this message
wlx (wangliangxu) wrote :

same problem happened in ubuntu 13.10.

Changed in bluefish:
importance: Unknown → Medium
status: Unknown → Incomplete
Revision history for this message
Lem (lem-jjr) wrote :

This bug has been fixed upstream, see this blog post by Olivier Sessink: http://oli4444.wordpress.com/2013/11/05/a-weird-for-loop

I applied his simple fix (reversing the direction of one of the loops in bftextview2_patcompile.c around line 516), and it fixed PHP comment syntax highlighting for me.

I've created a debdiff , it's very basic so if another patch format is required it's easy to do it manually. I'm not a developer or anything, but I've done this before with Audacious in Ubuntu, and the maintainer seemed to work with it fine..

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Fix PHP comment syntax highlighting" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Michael Terry (mterry) wrote :

Thanks, Lem! I uploaded your patch to trusty.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bluefish - 2.2.4-2ubuntu1

---------------
bluefish (2.2.4-2ubuntu1) trusty; urgency=low

  * Fix syntax highlighting of PHP comments where single line comments would
    not always terminate at a newline character. Thanks to Olivier Sessink for
    the bug fix. Fix also included upstream (LP: #1242387).
 -- Jason Rainforest <email address hidden> Sat, 30 Nov 2013 12:28:05 +1000

Changed in bluefish (Ubuntu):
status: Confirmed → Fix Released
Changed in bluefish:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.