default logging level for agents uses a hack
Bug #1237731 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
High
|
Tim Penhey | ||
Bug Description
We want agents to log using level = DEBUG by default. This default is to be used only if the user has not specified a level using a logging-config value or an environment variable, nor have they change loggo's default config. We currently use a string comparison to see if loggo's config has been changed to something other than the default. This needs to be done using something better.
yuck:
loggoConfig := loggo.LoggerInfo()
if loggoConfig != "<root>=WARNING" {
.....
}
Related branches
lp:~thumper/juju-core/fix-charm-logging
- Juju Engineering: Pending requested
-
Diff: 659 lines (+244/-82)14 files modifiedcmd/juju/help_topics.go (+66/-0)
cmd/juju/main.go (+1/-0)
cmd/juju/main_test.go (+2/-1)
cmd/jujud/main.go (+38/-1)
cmd/logging.go (+18/-3)
cmd/logging_test.go (+1/-1)
environs/config/config.go (+26/-18)
environs/config/config_test.go (+16/-14)
state/apiserver/logger/logger_test.go (+5/-4)
testing/testbase/log.go (+1/-0)
worker/uniter/context.go (+13/-5)
worker/uniter/jujuc/juju-log.go (+21/-11)
worker/uniter/jujuc/juju-log_test.go (+33/-24)
worker/uniter/jujuc/util_test.go (+3/-0)
| Changed in juju-core: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 1.17.1 |
Revision history for this message
| Martin Packman (gz) wrote | #1 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in the associated branch.