suspend/gpu_lockup_after_suspend: Failed to close window

Bug #1237199 reported by Yung Shen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
checkbox (Ubuntu)
Fix Released
High
Daniel Manrique

Bug Description

Unable to finish gpu_lockup test, which prevents following tests.

Manually closed glxgears and browser windows will cause testing fail in submission, but next tests will be continue without problems.

From submission log:

WARNING: Got an exception Command 'wmctrl -l | grep glxgears' returned non-zero exit status 1
WARNING: Window 0 not found, not rotating it.
Traceback (most recent call last):
  File "/usr/share/checkbox/scripts/gpu_test", line 228, in <module>
    sys.exit(main())
  File "/usr/share/checkbox/scripts/gpu_test", line 177, in main
    GlxRotate[i].start()
IndexError: list index out of range

Tags: scripts

Related branches

Revision history for this message
Daniel Manrique (roadmr) wrote :

Rev 2398 introduced a fix for this kind of problem, but what you're seeing here is a case where the fix doesn't work (actually it was wrong from the beginning:

       if hasattr(GlxWindows[i], "id"):
            GlxRotate.append(RotateGlxThread(GlxWindows[i].id, i + 1))
            GlxRotate[i].start()

Say we try to start two windows, 0 and 1. For some reason, we fail to obtain the id for window 0. So:

i=0
GlxWindows[0].id does not exist, we do nothing in the above check.

i=1
GlxWindows[1].id exists, so:
 - We append a RotateGlxThread to GlxRotate (which was empty as window 0 wasn't added), pointing to GlxWindows[1] which does exist.
 - We try to start rotation on GlxRotate[1] <- But notice, this element does NOT exist because window 0 was never added, so window 1 is actually in slot 0.

I'll get this fixed right away, thanks for reporting this!

Changed in checkbox (Ubuntu):
assignee: nobody → Daniel Manrique (roadmr)
importance: Undecided → High
status: New → In Progress
Daniel Manrique (roadmr)
Changed in checkbox (Ubuntu):
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.