Mir fails to start if there's a stale socket
Bug #1235159 reported by
Michał Sawicz
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Unity8 on Mir fails to start if there's a stale /tmp/mir_socket. I understand this is somewhat by design: bug #1216237, but the "right" way seems to be that it would check if the socket is stale and only bail out if it's not?
Another point is that IIRC it stalls on startup in that case instead of exiting with an error code.
Related branches
lp:~alan-griffiths/mir/remove-endpoint-first-when-shutting-down
- Alexandros Frantzis (community): Approve
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Eleni Maria Stea (community): Approve
-
Diff: 286 lines (+146/-3)8 files modifiedexamples/render_surfaces.cpp (+1/-0)
include/server/mir/frontend/connector.h (+1/-0)
src/server/frontend/published_socket_connector.cpp (+10/-1)
src/server/frontend/published_socket_connector.h (+4/-0)
src/server/run_mir.cpp (+36/-0)
tests/acceptance-tests/test_server_shutdown.cpp (+92/-2)
tests/integration-tests/shell/test_session.cpp (+1/-0)
tests/integration-tests/test_display_server_main_loop_events.cpp (+1/-0)
Revision history for this message
| Michał Sawicz (saviq) wrote | #1 |
Revision history for this message
| Michał Sawicz (saviq) wrote | #2 |
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #3 |
| Changed in mir (Ubuntu): | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | #4 |
| Changed in mir (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| status: | Confirmed → In Progress |
| Changed in mir (Ubuntu): | |
| status: | In Progress → Triaged |
| assignee: | Alan Griffiths (alan-griffiths) → nobody |
| Changed in mir (Ubuntu): | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
Revision history for this message
| Michael Terry (mterry) wrote | #5 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #6 |
| Changed in mir (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in mir (Ubuntu): | |
| status: | Fix Released → Triaged |
| Changed in mir: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| Changed in mir (Ubuntu): | |
| assignee: | Alan Griffiths (alan-griffiths) → nobody |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #7 |
| Changed in mir: | |
| status: | Triaged → Fix Committed |
| Changed in mir (Ubuntu): | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #8 |
| Changed in mir (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in mir: | |
| milestone: | none → phone-v1-freeze |
| Changed in mir: | |
| milestone: | phone-v1-freeze → 0.0.15 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I wonder if the unity8 upstart job could handle that - after all, when you're (re)starting it, it should, arguably, just drop the socket that's there?