provider/null: sporadic test failure
Bug #1234125 reported by
Roger Peppe
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
Undecided
|
Andrew Wilkins |
Bug Description
About 1 in 4 test runs, I see the following failure:
FAIL: environ_
environ_
c.Assert(err, gc.ErrorMatches, "exit code 99")
... error string = "failed to flush input: write |1: broken pipe"
... regex string = "exit code 99"
OOPS: 0 passed, 1 FAILED
--- FAIL: Test (0.06 seconds)
It looks like the issue is that the fake ssh command is exiting and therefore
we can't write the command to it. That's actually a potential issue
with the real ssh command too - if it fails early, we will only see
"write on closed pipe", not the actual failure,
so I think this isn't just a matter of a bad test.
Related branches
lp:~axwalk/juju-core/lp1234125-fix-test-race
- Juju Engineering: Pending requested
-
Diff: 156 lines (+86/-14)3 files modifiedenvirons/sshstorage/storage.go (+40/-13)
environs/sshstorage/storage_test.go (+36/-0)
provider/null/environ_test.go (+10/-1)
Changed in juju-core: | |
assignee: | nobody → Andrew Wilkins (axwalk) |
tags: | added: intermittent-failure |
Changed in juju-core: | |
status: | New → In Progress |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
To post a comment you must log in.