Create invoice from Order line... Make both wizard same on sales as well as for purchase

Hello Alexandre,

Let me share my point of view here!

I don't think we required the default date on stock.invoice.onshipping wizard because it will change the invoice date. Here we have to make the consistency on 3 flow.
1) Manual create invoice
2) Create invoice from delivery order.
3) Create Invoice from sale order line.

*Invoice Date: When we create the manual invoice then invoice date is blank because invoice date means confirmation date for that invoice. So Invoice date will be write when you open the invoice. Basically the process of invoice is as follow (Mainly for sales invoice) . User created the invoice set invoice as pro-forma state and print the invoice and waiting for customer approval . When customer approved the invoice then accountant/Account manager will be validated that invoice then invoice date will be write the current date. This behavior is correct.

Now the 2nd way, Accountant can able to assign the invoice date manually when he/she creates the invoice and its on draft state.
So whenever accountant validated the invoice it will take the same assigned invoice date not the current date when you validate the invoice date.

This is the behavior of invoice date when invoice created manually without from the sales order line or Delivery order. So we have to make all behavior as a same for this.

2) Create invoice from delivery order.
It will open the pop-up wizard you can select the journal as well as invoice date and invoice date is blank which is quite fine here.
If user want to set the invoice date then he can enter and it will come as a invoice date on invoice from . Here *I do not agree that we have to put current system date on wizard's invoice date because it will affected to the invoice date which the exactly the date when you want to confirm the invoice* . So current behavior is also fine for me.

3)Create Invoice from sale order line.
*Here I faced the misbehavior*. When we creates the invoice from the sale order line invoice date will be same as the current date which is wrong because If user want the date of confirmation of invoice there then it should be wrong. Better we can do like in this manner, We have put the journal and invoice date on sale.order.line.make.invoice wizard. So user can able to select the invoice date, other wise it will not effect on invoice date if he didn't select any date.

So all behavior will go with same manner and we can avoid the inconsistency.

You can share your suggestion for this.

Thanks for the reporting!

Thanks Amit for this clear explanation

So basically, you agree with the bug report, but think I've fixed the wrong wizard.

That's fine with me... unfortunately the other one is more work to fix... I'll see what I can do in this regard.

Hello,

It has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1231856-ssh

revision-id: 9031

revno: <email address hidden>

It will be available in trunk soon.