Checkbox

job_list is not restored as is, but has more jobs

Bug #1229087 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Critical
Zygmunt Krynicki

Bug Description

job_list is not restored exactly as it was (it has more jobs), this "works" but gives users more jobs (the pre-filtering that the gui does is lost)

Tags: plainbox

Related branches

lp:~zyga/checkbox/job-list-resume
Daniel Manrique (community): Approve
Diff: 272 lines (+183/-4)
3 files modified
plainbox/plainbox/impl/service.py (+41/-0)
plainbox/plainbox/impl/session/resume.py (+36/-3)
plainbox/plainbox/impl/session/test_resume.py (+106/-1)
lp:~zyga/checkbox/trim-feature
Brendan Donegan (community): Approve
Diff: 269 lines (+184/-20)
4 files modified
plainbox/plainbox/abc.py (+19/-0)
plainbox/plainbox/impl/applogic.py (+1/-20)
plainbox/plainbox/impl/session/state.py (+75/-0)
plainbox/plainbox/impl/session/test_state.py (+89/-0)
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is the expected behavior of the resume API but I agree that we should change it. Should be very simple.

Changed in checkbox:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
importance: Undecided → Low
status: New → In Progress
tags: added: plainbox
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Bumping this to critical as apparently without this the run manager will be corrupted.

Changed in checkbox:
importance: Low → Critical
Revision history for this message
Daniel Manrique (roadmr) wrote :

This bug would benefit from a set of steps to reproduce. I used the stub2 whitelist and was unable to reproduce it:

- Clean the session directory
- Start plainbox -c stub service
- Start gui client
- Select stub2 whitelist only
- Start testing
- Close gui client on the first manual test
- Restart plainbox and gui client
- Select "rerun"

I get the list of tests without the categories (probably because we're not rerunning local jobs so the categories get lost), but the set of tests that are shown are the same as before.

Revision history for this message
Zygmunt Krynicki (zyga) wrote : Re: [Bug 1229087] Re: job_list is not restored as is, but has more jobs

You have just made me realize why we loose the hierarchy in the run
manager! Please open a new bug titled "JobDefinition.via is not preserved
by suspend resume".

Thanks
ZK

On Tue, Sep 24, 2013 at 7:44 PM, Daniel Manrique <
<email address hidden>> wrote:

> This bug would benefit from a set of steps to reproduce. I used the
> stub2 whitelist and was unable to reproduce it:
>
> - Clean the session directory
> - Start plainbox -c stub service
> - Start gui client
> - Select stub2 whitelist only
> - Start testing
> - Close gui client on the first manual test
> - Restart plainbox and gui client
> - Select "rerun"
>
> I get the list of tests without the categories (probably because we're
> not rerunning local jobs so the categories get lost), but the set of
> tests that are shown are the same as before.
>
> --
> You received this bug notification because you are a member of Checkbox
> Bug Wranglers, which is subscribed to checkbox.
> https://bugs.launchpad.net/bugs/1229087
>
> Title:
> job_list is not restored as is, but has more jobs
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/checkbox/+bug/1229087/+subscriptions
>

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Actually, it is restored correctly, bummer

On Tue, Sep 24, 2013 at 8:44 PM, Zygmunt Krynicki <
<email address hidden>> wrote:

> You have just made me realize why we loose the hierarchy in the run
> manager! Please open a new bug titled "JobDefinition.via is not preserved
> by suspend resume".
>
> Thanks
> ZK
>
>
>
> On Tue, Sep 24, 2013 at 7:44 PM, Daniel Manrique <
> <email address hidden>> wrote:
>
>> This bug would benefit from a set of steps to reproduce. I used the
>> stub2 whitelist and was unable to reproduce it:
>>
>> - Clean the session directory
>> - Start plainbox -c stub service
>> - Start gui client
>> - Select stub2 whitelist only
>> - Start testing
>> - Close gui client on the first manual test
>> - Restart plainbox and gui client
>> - Select "rerun"
>>
>> I get the list of tests without the categories (probably because we're
>> not rerunning local jobs so the categories get lost), but the set of
>> tests that are shown are the same as before.
>>
>> --
>> You received this bug notification because you are a member of Checkbox
>> Bug Wranglers, which is subscribed to checkbox.
>> https://bugs.launchpad.net/bugs/1229087
>>
>> Title:
>> job_list is not restored as is, but has more jobs
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/checkbox/+bug/1229087/+subscriptions
>>
>
>

Zygmunt Krynicki (zyga)
Changed in checkbox:
status: In Progress → Fix Committed
Brendan Donegan (brendan-donegan)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.