If the hash algroithm is not correct the daemon does not return a DBus error
Bug #1228246 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-download-manager |
Fix Released
|
High
|
Manuel de la Peña | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The daemon uses a default algorithm when it should return an error.
Related branches
lp:~mandel/ubuntu-download-manager/valid-hash-method
- Roberto Alsina (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
- Diego Sarmentero (community): Approve
-
Diff: 824 lines (+188/-70)19 files modifiedlibubuntudownloadmanager/download_factory.cpp (+6/-6)
libubuntudownloadmanager/download_factory.h (+3/-4)
libubuntudownloadmanager/download_manager.cpp (+5/-7)
libubuntudownloadmanager/group_download.cpp (+15/-5)
libubuntudownloadmanager/group_download.h (+2/-2)
libubuntudownloadmanager/hash_algorithm.cpp (+8/-0)
libubuntudownloadmanager/hash_algorithm.h (+4/-0)
libubuntudownloadmanager/single_download.cpp (+11/-3)
libubuntudownloadmanager/single_download.h (+1/-2)
ubuntu-download-manager-tests/fake_download.cpp (+1/-1)
ubuntu-download-manager-tests/fake_download.h (+1/-1)
ubuntu-download-manager-tests/fake_download_factory.cpp (+3/-3)
ubuntu-download-manager-tests/fake_download_factory.h (+3/-3)
ubuntu-download-manager-tests/test_download.cpp (+50/-14)
ubuntu-download-manager-tests/test_download.h (+4/-1)
ubuntu-download-manager-tests/test_download_factory.cpp (+11/-10)
ubuntu-download-manager-tests/test_downloads_db.cpp (+4/-6)
ubuntu-download-manager-tests/test_group_download.cpp (+52/-1)
ubuntu-download-manager-tests/test_group_download.h (+4/-1)
| Changed in ubuntu-download-manager: | |
| status: | Triaged → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in ubuntu-download-manager: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-download-manager: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 138, scheduled for release in ubuntu-