Ubuntu
click package

Version control meta directories should be filtered out

Bug #1223640 reported by Andrew Starr-Bochicchio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
click (Ubuntu)
Fix Released
Medium
Colin Watson

Bug Description

Working on my first click package, I noticed that the .bzr control directory is getting included in the package. This doesn't seem ideal and will begin to increase the size of the package overtime.

$ click contents com.ubuntu.developer.andrewsomething.stackbrowser_0.1_all.click
drwxr-xr-x root/root 0 2013-09-10 22:46 ./
-rw-r--r-- root/root 2749 2013-09-09 21:11 ./StackListModel.qml
-rw-r--r-- root/root 6078 2013-09-09 19:02 ./UserView.qml
-rw-r--r-- root/root 1626 2013-09-09 16:51 ./AnswerDelegate.qml
-rw-r--r-- root/root 6470 2013-09-10 22:41 ./stackbrowser.png
drwxr-xr-x root/root 0 2013-09-09 17:50 ./lib/
-rw-r--r-- root/root 3935 2013-09-09 17:50 ./lib/dateutils.js
-rw-r--r-- root/root 4062 2013-09-08 12:36 ./lib/jsonpath.js
-rw-r--r-- root/root 7927 2013-09-10 22:44 ./stackbrowser.qmlproject.user
-rw-r--r-- root/root 2640 2013-09-08 12:36 ./TagBrowser.qml
-rw-r--r-- root/root 179 2013-09-10 22:46 ./stackbrowser.desktop
-rw-r--r-- root/root 1451 2013-09-09 17:55 ./README
-rw-r--r-- root/root 99 2013-09-10 22:46 ./stackbrowser.json
-rw-r--r-- root/root 4485 2013-09-09 12:06 ./ShareComponent.qml
drwxr-xr-x root/root 0 2013-09-08 12:36 ./.bzr/
-rw-r--r-- root/root 35 2013-09-08 12:35 ./.bzr/branch-format
drwxr-xr-x root/root 0 2013-09-08 12:35 ./.bzr/branch-lock/
-rw-r--r-- root/root 147 2013-09-08 12:35 ./.bzr/README
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/branch/
-rw-r--r-- root/root 0 2013-09-08 12:36 ./.bzr/branch/tags
-rw-r--r-- root/root 39 2013-09-08 12:36 ./.bzr/branch/format
-rw-r--r-- root/root 140 2013-09-08 12:39 ./.bzr/branch/branch.conf
-rw-r--r-- root/root 55 2013-09-09 22:45 ./.bzr/branch/last-revision
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/branch/lock/
drwxr-xr-x root/root 0 2013-09-09 22:42 ./.bzr/checkout/
-rw-r--r-- root/root 27 2013-09-09 22:22 ./.bzr/checkout/conflicts
-rw-r--r-- root/root 0 2013-09-08 12:36 ./.bzr/checkout/views
drwxr-xr-x root/root 0 2013-09-09 22:42 ./.bzr/checkout/shelf/
-rw-r--r-- root/root 2569 2013-09-09 22:42 ./.bzr/checkout/shelf/shelf-2
-rw-r--r-- root/root 17266 2013-09-08 17:58 ./.bzr/checkout/shelf/shelf-1
-rw-r--r-- root/root 6398 2013-09-09 22:45 ./.bzr/checkout/dirstate
-rw-r--r-- root/root 40 2013-09-08 12:36 ./.bzr/checkout/format
-rw-r--r-- root/root 140 2013-09-09 19:17 ./.bzr/checkout/merge-hashes
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/checkout/lock/
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/repository/
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/repository/upload/
-rw-r--r-- root/root 54 2013-09-08 12:35 ./.bzr/repository/format
-rw-r--r-- root/root 257 2013-09-09 22:45 ./.bzr/repository/pack-names
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/repository/indices/
-rw-r--r-- root/root 272 2013-09-09 22:45 ./.bzr/repository/indices/cee96cc6da4bd937a8799672ee782a81.tix
-rw-r--r-- root/root 151 2013-09-09 22:22 ./.bzr/repository/indices/12d97f751877f3facf6180d44654cec3.cix
-rw-r--r-- root/root 180 2013-09-09 18:52 ./.bzr/repository/indices/971505efa3b5a0538ceac5cbe53c31d3.iix
-rw-r--r-- root/root 1194 2013-09-08 12:36 ./.bzr/repository/indices/0b0c515f1986fa0e04a1e4cc59e40ccc.cix
-rw-r--r-- root/root 181 2013-09-09 18:52 ./.bzr/repository/indices/971505efa3b5a0538ceac5cbe53c31d3.rix
-rw-r--r-- root/root 822 2013-09-08 12:35 ./.bzr/repository/indices/0b0c515f1986fa0e04a1e4cc59e40ccc.rix
-rw-r--r-- root/root 182 2013-09-09 22:22 ./.bzr/repository/indices/12d97f751877f3facf6180d44654cec3.iix
-rw-r--r-- root/root 2303 2013-09-08 12:35 ./.bzr/repository/indices/0b0c515f1986fa0e04a1e4cc59e40ccc.tix
-rw-r--r-- root/root 744 2013-09-09 17:58 ./.bzr/repository/indices/c46388218f8f117e526786d56d60df24.tix
-rw-r--r-- root/root 257 2013-09-09 18:52 ./.bzr/repository/indices/971505efa3b5a0538ceac5cbe53c31d3.tix
-rw-r--r-- root/root 182 2013-09-09 22:22 ./.bzr/repository/indices/12d97f751877f3facf6180d44654cec3.rix
-rw-r--r-- root/root 263 2013-09-09 17:58 ./.bzr/repository/indices/c46388218f8f117e526786d56d60df24.iix
-rw-r--r-- root/root 72 2013-09-08 12:35 ./.bzr/repository/indices/0b0c515f1986fa0e04a1e4cc59e40ccc.six
-rw-r--r-- root/root 216 2013-09-09 22:22 ./.bzr/repository/indices/12d97f751877f3facf6180d44654cec3.tix
-rw-r--r-- root/root 820 2013-09-08 12:35 ./.bzr/repository/indices/0b0c515f1986fa0e04a1e4cc59e40ccc.iix
-rw-r--r-- root/root 72 2013-09-09 17:58 ./.bzr/repository/indices/c46388218f8f117e526786d56d60df24.six
-rw-r--r-- root/root 186 2013-09-09 22:45 ./.bzr/repository/indices/cee96cc6da4bd937a8799672ee782a81.cix
-rw-r--r-- root/root 178 2013-09-09 22:45 ./.bzr/repository/indices/cee96cc6da4bd937a8799672ee782a81.rix
-rw-r--r-- root/root 264 2013-09-09 17:58 ./.bzr/repository/indices/c46388218f8f117e526786d56d60df24.rix
-rw-r--r-- root/root 72 2013-09-09 22:22 ./.bzr/repository/indices/12d97f751877f3facf6180d44654cec3.six
-rw-r--r-- root/root 151 2013-09-09 18:52 ./.bzr/repository/indices/971505efa3b5a0538ceac5cbe53c31d3.cix
-rw-r--r-- root/root 72 2013-09-09 18:52 ./.bzr/repository/indices/971505efa3b5a0538ceac5cbe53c31d3.six
-rw-r--r-- root/root 334 2013-09-09 17:58 ./.bzr/repository/indices/c46388218f8f117e526786d56d60df24.cix
-rw-r--r-- root/root 178 2013-09-09 22:45 ./.bzr/repository/indices/cee96cc6da4bd937a8799672ee782a81.iix
-rw-r--r-- root/root 72 2013-09-09 22:45 ./.bzr/repository/indices/cee96cc6da4bd937a8799672ee782a81.six
drwxr-xr-x root/root 0 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/
-rw-r--r-- root/root 185 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.cix
-rw-r--r-- root/root 72 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.six
-rw-r--r-- root/root 178 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.rix
-rw-r--r-- root/root 180 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.rix
-rw-r--r-- root/root 10965 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.pack
-rw-r--r-- root/root 181 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.iix
-rw-r--r-- root/root 352 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.tix
-rw-r--r-- root/root 72 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.six
-rw-r--r-- root/root 186 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.cix
-rw-r--r-- root/root 182 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.rix
-rw-r--r-- root/root 181 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.iix
-rw-r--r-- root/root 186 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.cix
-rw-r--r-- root/root 72 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.six
-rw-r--r-- root/root 376 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.tix
-rw-r--r-- root/root 72 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.six
-rw-r--r-- root/root 182 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.iix
-rw-r--r-- root/root 150 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.cix
-rw-r--r-- root/root 10035 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.pack
-rw-r--r-- root/root 181 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.iix
-rw-r--r-- root/root 4075 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.pack
-rw-r--r-- root/root 214 2013-09-08 13:00 ./.bzr/repository/obsolete_packs/9c0709818fc1ba691a3e8828b2089fd9.tix
-rw-r--r-- root/root 182 2013-09-08 12:39 ./.bzr/repository/obsolete_packs/564edbda8cc079feeee5a1444bdab792.rix
-rw-r--r-- root/root 10658 2013-09-09 12:07 ./.bzr/repository/obsolete_packs/3539a35048f5332b13eaef74ed59526b.pack
-rw-r--r-- root/root 459 2013-09-09 17:58 ./.bzr/repository/obsolete_packs/f6cba9193d7996f9185eab31ee72281c.tix
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/repository/lock/
drwxr-xr-x root/root 0 2013-09-09 22:45 ./.bzr/repository/packs/
-rw-r--r-- root/root 6183 2013-09-09 18:52 ./.bzr/repository/packs/971505efa3b5a0538ceac5cbe53c31d3.pack
-rw-r--r-- root/root 3889 2013-09-09 22:45 ./.bzr/repository/packs/cee96cc6da4bd937a8799672ee782a81.pack
-rw-r--r-- root/root 38666 2013-09-08 12:36 ./.bzr/repository/packs/0b0c515f1986fa0e04a1e4cc59e40ccc.pack
-rw-r--r-- root/root 4594 2013-09-09 22:22 ./.bzr/repository/packs/12d97f751877f3facf6180d44654cec3.pack
-rw-r--r-- root/root 15271 2013-09-09 17:58 ./.bzr/repository/packs/c46388218f8f117e526786d56d60df24.pack
-rw-r--r-- root/root 920 2013-09-08 12:36 ./stackbrowser.qmlproject
-rw-r--r-- root/root 10261 2013-09-09 11:58 ./stackbrowser.qml
drwxr-xr-x root/root 0 2013-09-08 18:04 ./graphics/
-rw-r--r-- root/root 1058 2013-09-08 12:36 ./graphics/go-to.svg
-rw-r--r-- root/root 2417 2013-09-08 12:36 ./graphics/tags.svg
-rw-r--r-- root/root 1319 2013-09-08 12:36 ./graphics/toolbarIcon@8.png
-rw-r--r-- root/root 5120 2013-08-29 16:21 ./graphics/share.svg
-rw-r--r-- root/root 35147 2013-09-08 12:36 ./COPYING
-rw-r--r-- root/root 62 2013-09-08 12:36 ./.bzrignore
-rw-r--r-- root/root 1855 2013-09-09 16:51 ./QuestionDelegate.qml
-rw-r--r-- root/root 3493 2013-09-08 12:36 ./UserBrowser.qml
-rw-r--r-- root/root 9721 2013-09-09 22:42 ./QuestionView.qml
-rw-r--r-- root/root 2803 2013-09-09 22:20 ./StackListView.qml

Tags: appstore

Related branches

lp:click
Colin Watson: Approve
Ubuntu CI managed package branches: Pending requested
Diff: 485 lines (+269/-70)
11 files modified
README (+1/-0)
click/build.py (+10/-22)
click/framework.py (+138/-0)
click/install.py (+8/-28)
click/paths.py.in (+1/-0)
click/tests/helpers.py (+29/-0)
click/tests/test_build.py (+39/-5)
click/tests/test_install.py (+2/-4)
debian/changelog (+8/-0)
doc/file-format.rst (+1/-2)
doc/index.rst (+32/-9)
lp:ubuntu/saucy-proposed/click
lp:~ubuntu-managed-branches/click/click (Merged)
Revision history for this message
Colin Watson (cjwatson) wrote :

I generally recommend copying the necessary files into a staging directory before building the package, but you're right that this behaviour isn't ideal. This is related to bug 1219912, although not quite the same.

Changed in click (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
tags: added: appstore
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

The package was built using the SDK. Maybe the Filtering should happen at that level of the tool chain.

Revision history for this message
Colin Watson (cjwatson) wrote :

See also bug 1227896.

Colin Watson (cjwatson)
Changed in click (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click - 0.4.7

---------------
click (0.4.7) saucy; urgency=low

  * Run system hooks when removing a package from the file system
    (LP: #1227681).
  * If a hook symlink is already correct, don't unnecessarily remove and
    recreate it.
  * Improve "click hook install-system" and "click hook install-user" to
    remove any stale symlinks they find, and to run Exec commands only once
    per hook. This significantly speeds up system and session startup when
    lots of applications are installed (LP: #1227604).
  * Rename "click hook install-system" and "click hook install-user" to
    "click hook run-system" and "click hook run-user" respectively, to
    better fit their semantics. (I expect these commands only to have been
    used internally by click's own Upstart jobs.)
  * Filter version control metadata and editor backup files out of binary
    packages in "click build" (LP: #1223640).
 -- Colin Watson <email address hidden> Fri, 20 Sep 2013 18:07:13 +0100

Changed in click (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

I agree, sdk should bzr export (or simil)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.