Do not hard code the phablet user
Bug #1223363 reported by
Pat McGowan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| qtcreator-plugin-ubuntu |
Fix Released
|
Low
|
Juhapekka Piiroinen | ||
Bug Description
A reminder to revise use of the phablet user to be somehow dynamic or parameter driven.
Related branches
lp:~juhapekka-piiroinen/qtcreator-plugin-ubuntu/fix-bug-1223363
- Timo Jyrinki: Approve
- PS Jenkins bot: Approve (continuous-integration)
- Zoltan Balogh: Pending requested
-
Diff: 1967 lines (+719/-498)21 files modifieddebian/changelog (+2/-0)
share/qtcreator/ubuntu/menu.json (+25/-9)
share/qtcreator/ubuntu/scripts/device_flashdaily (+1/-1)
share/qtcreator/ubuntu/scripts/device_flashdaily_bootstrap (+1/-1)
share/qtcreator/ubuntu/scripts/functions.inc (+1/-0)
share/qtcreator/ubuntu/scripts/openssh_connect (+2/-1)
share/qtcreator/ubuntu/scripts/openssh_publickey (+3/-3)
share/qtcreator/ubuntu/scripts/qtc_project_click_create (+4/-1)
share/qtcreator/ubuntu/scripts/qtc_project_click_createanddeploy (+11/-3)
src/ubuntu/ubuntubzr.cpp (+2/-2)
src/ubuntu/ubuntuconstants.h (+291/-133)
src/ubuntu/ubuntudeviceswidget.cpp (+191/-185)
src/ubuntu/ubuntudeviceswidget.ui (+4/-95)
src/ubuntu/ubuntumenu.cpp (+20/-10)
src/ubuntu/ubuntupackagingmode.cpp (+4/-4)
src/ubuntu/ubuntupackagingwidget.cpp (+17/-18)
src/ubuntu/ubuntuplugin.cpp (+10/-9)
src/ubuntu/ubuntusettingspage.cpp (+2/-1)
src/ubuntu/ubuntusettingspage.h (+1/-1)
src/ubuntu/ubuntusettingswidget.cpp (+39/-19)
src/ubuntu/ubuntusettingswidget.ui (+88/-2)
Revision history for this message
| Zoltan Balogh (bzoltan) wrote | #1 |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | New → Confirmed |
| Changed in qtcreator-plugin-ubuntu: | |
| assignee: | nobody → Juhapekka Piiroinen (juhapekka-piiroinen) |
Revision history for this message
| Juhapekka Piiroinen (juhapekka-piiroinen) wrote | #2 |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
On the Device/Advanced tab has a text area with the username. That holds now "phablet" by default and hardcoded in the src/ubuntu/
This usarename can be changed to a dynamic variable. We need to know how to get the username from the device.