Page in AccountCreationPage.qml does not set flickable property correctly from loaded plugin

Bug #1221845 reported by Mike McCracken
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Online Accounts setup for Ubuntu Touch
Fix Released
Medium
Alberto Mardegan
ubuntu-system-settings-online-accounts (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The automatic algorithm in the Page component for finding its flickable child fails when the flickable is inside a loaded child, as in a Main.qml loaded by AccountCreationPage.

If the flickable property isn't set, then the page's header doesn't hide as expected when you scroll the flickable.

AccountCreationPage needs to expose a way to set the flickable property manually - perhaps by expecting the plugin to expose a flickable property, then setting the page's flickable property to that object in an onLoaded handler.

Alberto Mardegan (mardy)
Changed in ubuntu-system-settings-online-accounts:
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-system-settings-online-accounts at revision 63, scheduled for release in ubuntu-system-settings-online-accounts, milestone Unknown

Changed in ubuntu-system-settings-online-accounts:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings-online-accounts - 0.2~+13.10.20131011-0ubuntu1

---------------
ubuntu-system-settings-online-accounts (0.2~+13.10.20131011-0ubuntu1) saucy; urgency=low

  [ Ken VanDine ]
  * Put the cancel button in a ListItem to ensure consistent spacing
    with other elements in system-settings.

  [ Andrew Starr-Bochicchio ]
  * Add loading indicator to OAuth page. (LP: #1235004)

  [ Alberto Mardegan ]
  * Delay destruction of the delegate until the edit page is popped Use
    ListView.delayRemove feature to delay the destruction of the
    delegate until we have removed the edit page from the stack. . (LP:
    #1231729)
  * Add a Cancel button to the OAuth authentication pages Use signon-
    ui's new X-PageComponent key to specify a QML page to be used. (LP:
    #1231691)
  * Close the WebView when the authentication is cancelled. (LP:
    #1231680)
  * AccountCreationPage: look for a "flickable" property from the
    plugin. (LP: #1221845)
  * Stop using deprecated gicon image provider .

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 65
 -- Ubuntu daily release <email address hidden> Fri, 11 Oct 2013 08:47:24 +0000

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Fix Released
dobey (dobey)
Changed in ubuntu-system-settings-online-accounts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.