plainbox needs to support the interpolation syntax in job descriptions

Bug #1220098 reported by Zygmunt Krynicki
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Checkbox
Won't Fix
High
Sylvain Pineau

Bug Description

Certain jobs use the '$output' syntax in their description. This is meant to be
used by jobs like 'user-verify' where the user is asked to verify that the
output of a job is good according to some criteria.

Related branches

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

EXAMPLE:

plugin: user-verify
name: graphics/resolution
requires:
 device.category == 'VIDEO'
command: resolution_test
estimated_duration: 0.750
_description:
 PURPOSE:
     This test will verify the default display resolution
 STEPS:
     1. This display is using the following resolution:
 INFO:
     $output
 VERIFICATION:
     Is this acceptable for your display?

Revision history for this message
Ara Pulido (ara) wrote :

This is not critical for now, but something we will need to fix when we want to adopt plainbox for checkbox and checkbox-certification

Changed in checkbox-ihv-ng:
status: New → Confirmed
importance: Undecided → High
Changed in checkbox:
status: New → Confirmed
Changed in checkbox-ihv-ng:
milestone: none → version1.3
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is a bit annoying since JobDefinition is immutable and I don't want to change that. We'll introduce appropriate APIs to get interpolated description field for a given job and session though. Just assign me to this whenever you want this fixed

Changed in checkbox:
status: Confirmed → Triaged
Chris Gregan (cgregan)
Changed in checkbox-ihv-ng:
milestone: version1.3 → version1.4
Chris Gregan (cgregan)
Changed in checkbox-ihv-ng:
milestone: version1.4 → version1.5
Changed in checkbox:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
Changed in checkbox-ihv-ng:
assignee: nobody → Sylvain Pineau (sylvain-pineau)
Changed in checkbox:
assignee: Zygmunt Krynicki (zkrynicki) → Sylvain Pineau (sylvain-pineau)
status: Triaged → In Progress
importance: Undecided → High
Changed in checkbox-ihv-ng:
status: Confirmed → In Progress
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

jobs relying on the interpolation feature are: graphics/resolution and networking/info children

The consensus is:

1) we should be able to work around the 2 tests needing $output, so
2) we may not need to implement that now, but
3) we still need to design a way to show command output to the user to help him decide outcomes (may be an adaptation of the log viewer)

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

graphics/resolution could be handle differently by creating an overlay with the screen resolution using qml, see: https://code.launchpad.net/~sylvain-pineau/checkbox/graphic_resolution_test_qml/+merge/199418

networking/info jobs should be replaced by their fully automated versions, see ethernet.txt.in and wireless.txt.in

So far we have ethernet/info_automated and a request to have its counterpart for wireless (see https://bugs.launchpad.net/checkbox/+bug/1262205)

tags: removed: plainbox
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox-ihv-ng:
status: In Progress → Fix Committed
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Re: [Bug 1220098] Re: plainbox needs to support the interpolation syntax in job descriptions

I think it's Won't Fix, another bug should be filed for what we actually did

On Mon, Jan 6, 2014 at 1:35 PM, Sylvain Pineau
<email address hidden> wrote:
> ** Changed in: checkbox
> Status: In Progress => Fix Committed
>
> ** Changed in: checkbox-ihv-ng
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a member of Checkbox
> Bug Wranglers, which is subscribed to checkbox.
> https://bugs.launchpad.net/bugs/1220098
>
> Title:
> plainbox needs to support the interpolation syntax in job
> descriptions
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/checkbox/+bug/1220098/+subscriptions

Changed in checkbox:
status: Fix Committed → Won't Fix
Changed in checkbox-ihv-ng:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.