urfkill crash due to missing RKILL_NFC type

Bug #1218567 reported by Tony Espy
42
This bug affects 4 people
Affects Status Importance Assigned to Milestone
urfkill (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Work is being done to leverage urfkill for "Flight Mode" support on Ubuntu Touch ( and potentially Desktop in the future ). See the following blueprint for details:

https://blueprints.launchpad.net/ubuntu/+spec/ubuntu-touch-flight-mode

When the current version of urfkill ( 0.4.0-4 ) is run on Saucy, it will crash due to the fact that urfkill's version of <rfkill.h> doesn't include the new NFC RFKILL type included by the <linux/rfkill.h>. This results in a runtime assertion during creation of urfkill's killswitch devices.

To recreate:

1. Build urfkill for armhf
2. Install on a current touch image
3. Create a urfkill.conf file with key_control=false
4. Start urfkill in the foreground and specify the config file mentioned in the previous step
5. urfkill will segfault in urf-utils.c:type_to_string() as there's no case for NFC

Note, this bug was reproduced on a Touch system, and as such requires a fix for bug #1218563 ( see linked branch ).

Tony Espy (awe)
Changed in urfkill (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package urfkill - 0.4.0-4ubuntu1

---------------
urfkill (0.4.0-4ubuntu1) trusty; urgency=low

  [ Tony Espy ]
  * debian/control: create urfkill-dbg package.
  * debian/rules: added dh_strip logic for new -dbg package.
  * debian/patches/02_fix_arm_profile_crash.patch: check for
    for the existence of DMI devices before creating an instance
    of DmiInfo to prevent a crash.
  * debian/patches/03_fix_nfc_crash.patch: add support for the
    new RFKILL_NFC type to prevent an assertion/crash. (LP: #1218567)

  [ Mathieu Trudel-Lapierre ]
  * debian/rules: use --with autotools_dev to update config.{sub,guess} on
    build so as to fix building on arm64.
 -- Mathieu Trudel-Lapierre <email address hidden> Mon, 09 Dec 2013 11:20:16 -0500

Changed in urfkill (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.