pt-duplicate-key-checker misses exact duplicate unique indexes
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
Bug Description
USE test
CREATE TABLE `domains` (
`id` bigint(20) NOT NULL,
`domain` varchar(175) COLLATE utf8_bin NOT NULL,
PRIMARY KEY (`id`),
UNIQUE KEY `domain` (`domain`),
UNIQUE KEY `unique_key_domain` (`domain`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;
QUIT
$ pt-duplicate-
# #######
# test.domains
# #######
# unique_key_domain (`domain`)
# domain (`domain`)
# PRIMARY (`id`)
# #######
# Summary of indexes
# #######
# Total Indexes 3
$ pt-duplicate-
pt-duplicate-
Related branches
- Daniel Nichter: Approve
-
Diff: 1776 lines (+873/-519)13 files modifiedbin/pt-duplicate-key-checker (+571/-490)
lib/DuplicateKeyFinder.pm (+26/-12)
lib/KeySize.pm (+17/-1)
t/lib/DuplicateKeyFinder.t (+61/-2)
t/lib/KeySize.t (+102/-4)
t/lib/samples/dupekeys/prefix_bug_1214114.sql (+7/-0)
t/lib/samples/dupekeys/simple_dupe_bug_1217013.sql (+7/-0)
t/pt-duplicate-key-checker/basics.t (+15/-4)
t/pt-duplicate-key-checker/clustered_keys.t (+15/-2)
t/pt-duplicate-key-checker/samples/bug-894140.txt (+1/-0)
t/pt-duplicate-key-checker/samples/fk_chosen_index_bug_1201443.sql (+21/-0)
t/pt-duplicate-key-checker/samples/simple_dupe_bug_1217013.txt (+21/-0)
t/pt-duplicate-key-checker/standard_options.t (+9/-4)
| Daniel Nichter (daniel-nichter) wrote | #1 |
| tags: | added: pt-duplicate-key-checker |
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| importance: | Undecided → Medium |
| milestone: | none → 2.2.6 |
| Changed in percona-toolkit: | |
| status: | Confirmed → In Progress |
| Daniel Nichter (daniel-nichter) wrote | #2 |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| summary: |
- pt-duplicate-key-checker misses duplicate keys + pt-duplicate-key-checker misses exact unique index duplicates |
| summary: |
- pt-duplicate-key-checker misses exact unique index duplicates + pt-duplicate-key-checker misses exact duplicate unique indexes |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
| Frank Cizmich (frank-cizmich) wrote | #4 |
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #5 |
Fascinating. There are tests for exact dupes--the simplest case. And I don't recall the index name being a factor. So I'm not sure what's wrong here but we'll find out.