Percona Server moved to https://jira.percona.com/projects/PS

5.6.12 removed UNIV_SYNC_DEBUG from UNIV_DEBUG

Bug #1216815 reported by Laurynas Biveinis on 2013-08-26

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
MySQL Server	Unknown	Unknown	mysql-bugs #69617
Percona Server moved to https://jira.percona.com/projects/PS	Fix Released	Medium	Laurynas Biveinis	Percona Server moved to https://jira.percona.com/projects/PS 5.6.13-60.6
5.1	Invalid	Undecided	Unassigned
5.5	Invalid	Undecided	Unassigned
5.6	Fix Released	Medium	Laurynas Biveinis	Percona Server moved to https://jira.percona.com/projects/PS 5.6.13-60.6

Bug Description

[28 Jun 19:10] Laurynas Biveinis

Description:
univ.i has this new line in 5.6.12 compared to 5.6.11:

#undef UNIV_SYNC_DEBUG

Line 174.

Bzr annotate points to [1], whose commit message does not mention this rather big change, nor the commit itself looks like it would be related to locking in any way.

Is it an unintended change that should be reverted?

[1]

5.6$ bzr log -r 5058 -n0
------------------------------------------------------------
revno: 5058 [merge]
committer: Marko Mäkelä <email address hidden>
branch nick: mysql-5.6
timestamp: Tue 2013-04-30 14:45:16 +0300
message:
  Merge mysql-5.5 to mysql-5.6.
    ------------------------------------------------------------
    revno: 2875.437.81
    committer: Marko Mäkelä <email address hidden>
    branch nick: mysql-5.5
    timestamp: Tue 2013-04-30 13:39:50 +0300
    message:
      Bug#16720368 INNODB IGNORES *.IBD FILE BREAKAGE AT STARTUP

      After a clean shutdown, InnoDB will not check the *.ibd file headers,
      for maximum performance. This is unchanged before and after this
      patch.

What this fix addresses is the case when crash recovery is
needed. Previously, InnoDB could load a corrupted tablespace file.

buf_page_is_corrupted(): Add the parameter check_lsn.

      fil_check_first_page(): New function, to perform a consistency check
      on the first page of a file. This can be overridden by setting
      innodb_force_recovery.

fil_read_first_page(), fil_open_single_table_tablespace(),
fil_load_single_table_tablespace(): Invoke fil_check_first_page().

open_or_create_data_files(): Check the status of
fil_open_single_table_tablespace().

rb#2352 approved by Jimmy Yang

How to repeat:
Open univ.i, search for UNIV_SYNC_DEBUG

Suggested fix:
Remove the #undef.

Tags:

Related branches

lp:~laurynas-biveinis/percona-server/ahi-partitions-5.6-5.6

Merged into lp:percona-server/5.6 at revision 420

Alexey Kopytov (community): Approve on 2013-08-29

Laurynas Biveinis (laurynas-biveinis) on 2013-08-26

tags:

added: innodb upstream

Revision history for this message

Laurynas Biveinis (laurynas-biveinis) wrote on 2014-02-03:

Upstream fix in 5.6.16 and 5.7.4.

Revision history for this message

Shahriyar Rzayev (rzayev-sehriyar) wrote on 2018-01-25:

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1411

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

mysql-bugs #69617 Edit

Bug watches keep track of this bug in other bug trackers.