VM

with-timeout macro not available at compile time, XEmacs

Bug #1208026 reported by Aidan Kehoe
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VM
Fix Committed
Medium
Uday Reddy

Bug Description

Someone (probably with the surname Welinder) reported bugginess with current tip VM when byte-compiled, and mentioned the following byte-compile warning in the bug report:

While compiling vm-imap-make-session in file
/home/welinder/vm/src/lisp/vm-imap.el:
  ** (or vm-imap-server-timeout 1000) is a malformed function
  ** (or vm-imap-server-timeout 1000) is a malformed function
  ** (or vm-imap-server-timeout 1000) is a malformed function
  ** (or vm-imap-server-timeout 1000) is a malformed function

This warning is because the #'with-timeout macro was not available at compile time, and as such evaluation of its arguments was broken and incorrect. The following patch eliminates the warning for me, though I haven't tested more intensively:

diff --git a/lisp/vm-build.el b/lisp/vm-build.el
index 2014849..75dd02b 100644
--- a/lisp/vm-build.el
+++ b/lisp/vm-build.el
@@ -56,6 +56,7 @@
 ;; Preload these to get macros right
 (require 'cl)
 (require 'sendmail)
+(require 'timer-funcs)

 ;; now add VM source dirs to load-path and preload some
 (setq load-path (append '("." "./lisp") load-path))

Related branches

Uday Reddy (reddyuday)
Changed in vm:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Uday Reddy (reddyuday)
milestone: none → 8.2.0b1
Uday Reddy (reddyuday)
Changed in vm:
status: Triaged → Fix Committed
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.2a → 8.2.1a
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.1a → 8.2.90a
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.