/usr/lib/ubiquity/wallpaper does not honour the aspect ratio of wallpaper image

Bug #1207249 reported by Hao-Ran Liu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Invalid
Undecided
Unassigned
Precise
Fix Released
Low
Unassigned
Saucy
Won't Fix
Undecided
Unassigned

Bug Description

[Impact]

 * Default background during installation is aesthetically unpleasant.

[Test Case]

 * Perform installation / oem-config of a flavour's desktop background aspect ration _not_ matching the screen aspect ratio, e.g. Ubuntu Kylin on a widescreen monitor

 * Make sure the image aspect ration is not distorted.

[Regression Potential]

 * This fix is not part of later release, as ubiquity-wallpaper is no longer used, in favor of Desktop Environment native wallpaper rendering

[Other Info]

Wallpaper is stretched during installation and oem-config with a wide screen monitor.

This bug affects ubiquity in precise. We backported UbuntuKylin Raring to Precise and met this issue. The background image of UbuntuKylin has a logo in the shape of round circle. But it is stretched into an oval.

Related branches

Hao-Ran Liu (hzliu123)
tags: added: raring
description: updated
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

It seems like screen resolution is completely miss-detected, as everything looks stretched (indicators are not square, cd-rom drive picture is not square, UbuntuKylin font doesn't look right)

How was this qemu instance launched? any special screen resolution parameters?

Hao-Ran Liu (hzliu123)
tags: added: precise
removed: raring
Hao-Ran Liu (hzliu123)
summary: - UbuntuKylin logo is stretched into an oval during installation
+ /usr/lib/ubiquity/wallpaper does not honour the aspect ratio of
+ wallpaper image
Hao-Ran Liu (hzliu123)
description: updated
Revision history for this message
Hao-Ran Liu (hzliu123) wrote :

@xnox,

The previous screenshot is incorrect. This one is captured from virtualbox. UbuntuKylin logo is stretched vertically.

Revision history for this message
Hao-Ran Liu (hzliu123) wrote :

I have pushed the patch to lp:~hzliu123/ubiquity/fix-stretched-wallpaper.lp1207249 and submitted a merge proposal.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I see, thanks for that. This is weird, as the wallpaper.c app shouldn't be used to display the wallpaper, instead gnome-settings-daemon should be running and showing the wallpaper (and as far as I understand gnome-settings-daemon is available on the default UbuntuKylin install / in the installer).

Revision history for this message
Hao-Ran Liu (hzliu123) wrote :

This bug only happens when wallpaper.c is used to display the wallpaper. wallpaper.c is used to display the wallpaper in Precise, but not in Raring or UbuntuKylin 13.04.

Hao-Ran Liu (hzliu123)
description: updated
Changed in ubiquity (Ubuntu Saucy):
status: New → Won't Fix
Changed in ubiquity (Ubuntu):
status: New → Invalid
Changed in ubiquity (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Low
description: updated
Revision history for this message
Stéphane Graber (stgraber) wrote : Please test proposed package

Hello Hao-Ran, or anyone else affected,

Accepted ubiquity into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubiquity/2.10.29 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubiquity (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I have cropped background and drew perfect square and circle shapes. The background image was zoomed, but the shapes were not distorted, they stayed as perfect square and circle.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.10.29

---------------
ubiquity (2.10.29) precise; urgency=low

  [ Dimitri John Ledkov ]
  * Show labels in automatic side-by-side installation. Fixed by removing
    all cairo styling from partition boxes in automatic partitioning,
    instead use simple bg styling. (LP: #947107, #1240532)
  * Automatic update of included source packages: grub-installer
    1.68ubuntu5.3.

  [ Brian Murray ]
  * Use the apt cache with with so that we close the cache when we are done
    with it. (LP: #1051935)

  [ Hao-Ran Liu (Joseph Liu) ]
  * src/wallpaper/wallpaper.c: Cropping wallpaper image instead of
    stretching it if image's aspect ratio doesn't match monitor's aspect
    ratio (LP: #1207249)

  [ Colin Watson ]
  * Update translations from Launchpad.
 -- Dimitri John Ledkov <email address hidden> Wed, 22 Jan 2014 14:35:56 +0000

Changed in ubiquity (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.