ValueError in report json
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
charmworld |
Fix Released
|
High
|
Abel Deuring |
Bug Description
Staging is unhappy with a recent change landed to fix report data date handling
2013-07-25 11:50:23 [19027] [ERROR] http://
Traceback (most recent call last):
...
File "/home/
return report_
File "/home/
categorize_
File "/home/
self.
File "/home/
raise ValueError(date)
ValueError: 978307343.151
Related branches
- Aaron Bentley (community): Approve
-
Diff: 95 lines (+50/-6)2 files modifiedcharmworld/reports.py (+3/-6)
charmworld/tests/test_reports.py (+47/-0)
Changed in charmworld: | |
status: | Triaged → Fix Committed |
assignee: | nobody → Abel Deuring (adeuring) |
Changed in charmworld: | |
status: | Fix Committed → Fix Released |
That failed date is 2001-01-01 which is dubious
It predates Juju, Ensamble, and Bazaar. This date might be a fail over value. The dates come from charm.changes[-1] which is fundamentally flawed because the changes list only contains the last 10 changes. charm.date_created is the most accurate guess of when a charm was created.