[DynamicNotebook] tab_added signal should not add an empty tab
Bug #1198513 reported by
Mario Guerriero
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Granite |
Fix Released
|
Undecided
|
Niclas Lockner | ||
Bug Description
tab_added signal now adds an empty tab when it is emitted. DynamicNotebook API should only emit this signal without doing anything else. It's a developer care to add the tab or not.
Related branches
lp:~mefrio-g/granite/1198513
- Cody Garver (community): Needs Information
-
Diff: 58 lines (+5/-9)2 files modifieddemo/main.vala (+3/-3)
lib/Widgets/DynamicNotebook.vala (+2/-6)
lp:~niclasl/granite/new-dn-api
- David Gomes (community): Approve
- Mario Guerriero: Pending requested
-
Diff: 598 lines (+168/-121)2 files modifieddemo/GraniteDemo.vala (+14/-8)
lib/Widgets/DynamicNotebook.vala (+154/-113)
| Changed in granite: | |
| assignee: | nobody → Mario Guerriero (mefrio-g) |
| Changed in granite: | |
| assignee: | Mario Guerriero (mefrio-g) → Niclas Lockner (niclasl) |
| Changed in granite: | |
| status: | New → In Progress |
| Changed in granite: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
