lava-deployment-tool smashes ownership on the entire user homedir

Hi Paul

I don't think I quite understand the issue fully, could you please add some details:

Do you mean l-d-t is overwriting permissions of your own personal home directory, or of the "lava-$instance" user that it has created, or a different lava instance user?

Were you deploying a new instance or upgrading an existing one? The change was done on the basis that the home folder which is being chown'd (/srv/lava/instances/$instance/home) has just been created by l-d-t so should be empty, is that not the case?

Thanks.

> Do you mean l-d-t is overwriting permissions of your own personal home directory, or of the "lava-$instance" user that it has created, or a different lava instance user?

It recursively overwrites ownership of files of my own personal home directory, because by default lava-deploy-tool doesn't create any users by uses current user (and that's intended behavior in my case).

> on the basis that the home folder which is being chown'd (/srv/lava/instances/$instance/home) has just been created by l-d-t so should be empty, is that not the case?

No, per above.

> Were you deploying a new instance or upgrading an existing one?

I just run it as "./lava-deployment-tool install -d <instname>" and use defaults for all choices.

Ok Paul, totally understood.

I had no idea that developer mode caused the LAVA_SYS_USER to be set as the current running user.

It looks like l-d-t only checks for the existence of ~/.ssh/id_rsa before going off on this folder creation and chown rampage, so I'll try to make it behave properly when in developer mode.

Agree it is critical.