Links to diffs from within a revision do not work

Bug #119422 reported by Nicholas Allen
2
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Medium
Robey Pointer

Bug Description

If I click on a revision link to see that page for that revision (where the files modifed, added and removed are shown) then if I click on the diff links to the right of the modified files nothing happens. It works, however, if I click the diff links on the main log page for a revision just not within the page for a revision.

Revision history for this message
Robey Pointer (robey) wrote :

i bet this is because you're in unified-diff view. Kent Gibson emailed today a request to "fix the diff links so they also work in unified view - at the moment they only work
in side-by-side. The anchor that the link refers to is currently within the sbs block and so isn't accessible when that block is hidden in unified view."

sounds like probably the same bug, and probably trivial to fix in the template.

Changed in loggerhead:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Robey Pointer (robey) wrote :

i think i fixed this in 144 on my dev branch. please re-open if i misunderstood the bug.

Changed in loggerhead:
assignee: nobody → robey
status: Confirmed → Fix Committed
Revision history for this message
Nicholas Allen (nick-allen) wrote :

I have just pulled the latest changes and now this bug is the other way round. It works on the page for a revision but not on the main page listing all revisions. If I try to go to a file diff there I am just taken to the top of the revision page.

Revision history for this message
Robey Pointer (robey) wrote :

hm, yeah, that's gonna be tough. it's not enough to have the right -u or -s link from the changelog page, because the link's initial position on the page may be wrong.

Revision history for this message
Robey Pointer (robey) wrote :

all i did with my previous change was move the bug. currently, if you use "unified" diff view, the "-> diff" links from the changelog page don't work. the problem is that the anchors are correct, but when the revision page first loads (before js runs), the unified blocks are default-hidden. so the anchor doesn't exist. making all blocks default-visible doesn't work, because once again, the js hides blocks and changes the anchor's location.

oddly, it looks like i can solve this by adding 'window.location.hash = window.location.hash' into the startup js for the revision page. good grief.

Changed in loggerhead:
status: Fix Committed → Confirmed
Revision history for this message
Robey Pointer (robey) wrote :

ok should be fixed in my branch @ 150.

Changed in loggerhead:
status: Confirmed → Fix Committed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Released in 1.2.

Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.