Ubuntu File Manager App

Add refresh action

Bug #1191282 reported by David Planella
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu File Manager App
Fix Released
Low
Carlos Jose Mazieri

Bug Description

Right now, if I look at the contents of a folder and they have changed externally (such as a file being deleted), the only way to refresh is to navigate away to another folder and back to the current folder.

It'd be nice for these external changes to be refreshed automatically, but if this cannot be implemented, it'd be nice to have a toolbar action to refresh the contents, or perhaps pulling the list from the top or bottom could do a refresh.

Carlos Jose Mazieri (carlos-mazieri)
Changed in ubuntu-filemanager-app:
assignee: nobody → Carlos Jose Mazieri (carlos-mazieri)
importance: Undecided → Low
status: New → Confirmed
Carlos Jose Mazieri (carlos-mazieri)
Changed in ubuntu-filemanager-app:
status: Confirmed → In Progress
Revision history for this message
Michael Spencer (ibelieve) wrote :

If you're going to add a refresh button, you should probably wait until this gets merged: https://code.launchpad.net/~mdspencer/ubuntu-filemanager-app/improved-toolbar/+merge/171639

A good place to put a refresh action might be in the Actions menu.

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

No, I am not going to add a refresh button.

The auto refresh action will be an external file system watcher that I plan to run on another thread, it will check for external changes made by other applications and will notify the file manager about the changes found.

Revision history for this message
Michael Spencer (ibelieve) wrote :

Good, that will be nice to have.

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

An auto refresh timer checks every 3 seconds if the current path has been modified since last modification, if so reads the directory and compares it with the current content.

This feature is disabled by default since the plugin is used by other applications like Music App.
To enable that in the UI:
          enableExternalFSWatcher: true

Files added/removed and modfied (size, modification time and permissions ) by other applications are refreshed.

Main code: file dirmodel.cpp
http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/plugin/view/head:/folderlistmodel/dirmodel.cpp#L1060
http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/plugin/view/head:/folderlistmodel/dirmodel.cpp#L1301

Main code: file iorequest.cpp
http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/plugin/view/head:/folderlistmodel/iorequest.cpp#L113
http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/plugin/view/head:/folderlistmodel/iorequest.cpp#L170

Changed in ubuntu-filemanager-app:
status: In Progress → Fix Committed
Michael Spencer (ibelieve)
Changed in ubuntu-filemanager-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.