MASTER Key management / Recipient Key Selection broken (endless loop in EnigConvertToUnicode)

Bug #119038 reported by Richard Lamont
30
Affects Status Importance Assigned to Milestone
enigmail (Ubuntu)
Fix Released
High
Alexander Sack
Dapper
Fix Released
Undecided
Alexander Sack
Edgy
Fix Released
Undecided
Alexander Sack
Feisty
Fix Released
Undecided
Alexander Sack
thunderbird (Ubuntu)
Invalid
Undecided
Unassigned
Dapper
Invalid
Undecided
Unassigned
Edgy
Invalid
Undecided
Unassigned
Feisty
Invalid
Undecided
Unassigned

Bug Description

SRU Info:

1. impact: Key Management broken, Key Recipient dialog broken
2. Addressed: patch 88_enigmail-fix-endless-loop-regression backports 0.95.x EnigConvertGpgToUnicode and EnigConvertToUnicode function ... which does not enter an infinite loop
3. Patch: debdiffs attached for all variants
4. Reproduce bug:
  a) Open OpenPGP -> Key Management dialog ... see that it enters infinite loop finally asking you if you want to cancel the running script
5. Regressions: No known Regressions; impact is considered low-risk

This is an endless loop in EnigConvertToUnicode ... fix in preparation

Feisty amd64.

ii mozilla-thunderbird 1.5.0.12-0ubuntu0.7.04
ii mozilla-thunderbird-enigmail 0.94.2-0ubuntu1
ii gnupg 1.4.6-1ubuntu2
ii seahorse 1.0.1-0ubuntu1

Following an apt-get upgrade a couple of days ago, in which mozilla-thunderbird was upgraded to the above version, it has become impossible to select keys in the Enigmail/OpenPGP extension.

If I go to OpenPGP -> OpenPGP Key Management, a window opens but instead of listing all the public keys on my keyring the table is empty and an error window opens up saying "A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete." There are two buttons - "Continue" and "Stop Script".

If I go to OpenPGP -> Edit Per_Recipient-Rules, and go through the dialogs to select a key that way, I end up with the same error message.

For recipients for whom I have already selected a key to be used every time, I can send and receive signed and encrypted emails normally.

gpg --list-keys works normally.

Revision history for this message
anke (anke-so36) wrote :

I can confirm this bug.

mozilla-thunderbird 1.5.0.12-0ubuntu0.7.04
mozilla-thunderbird-enigmail 0.94.2-0ubuntu1
gnupg 1.4.6-1ubuntu2

Revision history for this message
Alexander Sack (asac) wrote :

what does openpgp -> About dialog show you?

Changed in enigmail:
assignee: nobody → asac
status: Unconfirmed → Needs Info
Revision history for this message
Richard Lamont (richard-lamont) wrote :

It shows this:

OpenPGP provided by Enigmail

Running Enigmail version 0.94.2.0 (20070213)

Using gpg executable /usr/bin/gpg to encrypt and decrypt

Enigmail OpenPGP is developed by the Enigmail Team:

    * Lead Developer: Patrick Brunschwig
    * Code: Patrick Brunschwig, R. Saravanan
    * Usability and Testing: Barry Porter, John Clizbe, Olav Seyfarth, Shane M. Coughlan
    * User Support: Barry Porter, John Clizbe, Olav Seyfarth
    * Website Management: Olav Seyfarth, Shane M. Coughlan
    * Icons: Jochen Eisinger (Modern), Jan Gerber (Classic), Frank Gerhardt
    * Localization: See the Enigmail Language Packs page
    * Website hosting: mozdev.org

Enigmail OpenPGP is updated frequently. Visit the Enigmail OpenPGP download page to check for newer versions

Enigmail OpenPGP is open source and licensed under the GNU General Public License and the Mozilla Public License

Visit our homepage at http://enigmail.mozdev.org

Revision history for this message
anke (anke-so36) wrote :

It shows the same to me (in german) :

OpenPGP provided by Enigmail
Sie verwenden Enigmail Version 0.94.2.0 (20070213)
Benutze gpg Executable /usr/bin/gpg zur Ver- und Entschlüsselung
[...]

Revision history for this message
Rob Kuiters (rob-kuiters) wrote :

Hi,

I've also got the same problem. I didn't know that this was already addressed and did open a new one; 121352.

Cheers,
Rob

Revision history for this message
Richard Lamont (richard-lamont) wrote :

I created a new profile (mozilla-thunderbird -P) and set it up with a different POP3 email account. I was able to send and receive plain text and encrypted email, but the Key Management window brought up the same error as before.

Revision history for this message
Richard Lamont (richard-lamont) wrote :

Two other observations:

1. A few seconds elapses between opening the Key Management window and getting the error message. During this time mozilla-thunderbird-bin uses 100% CPU.
2. If I create a new user account on the same machine, it all works OK.

Revision history for this message
Alexander Sack (asac) wrote :

this bug is known to enigmail developers though the cause is not known. I will attach the patch for enigmail soon.

Changed in enigmail:
status: Incomplete → Confirmed
Revision history for this message
Alexander Sack (asac) wrote :

though probably caused by tbird in the first, place we will fix this on enigmail side.

Changed in thunderbird:
status: New → Invalid
Revision history for this message
sbg (stefan-b-grinneby) wrote :

It seems to me it has something to do with certain characters being present in the names of people in the keyring. At least, I can provoke this by adding swedish national characters in the "real name" of people owning keys in my ring - åäöÅÄÖ etc. Also, it might be something with the encoding - UTF-8 vs. ISO8859-1 - perhaps something about the encoding in the keyring being different than the current TB/EM one? Just guessing, sorry.

Revision history for this message
anke (anke-so36) wrote :

sbg, you are right. I had a "broken" é in one of the names of the keys in my keyring. When I removed it, everything works again. There is still one keyname wit an ü in it and one with a "broken" ä, that don't cause any problems.
Thanks for your "guess"!

Revision history for this message
Richard Lamont (richard-lamont) wrote :

I can confirm this. I deleted the one key on my keyring that contains non-Latin characters (a Chinese name with a .tw address) and now Enigmail's key management works again. Thanks to sbg and anke for the tip.

Revision history for this message
Rob Kuiters (rob-kuiters) wrote : Re: [Bug 119038] Re: Key management broken after Thunderbird upgrade

Indeed, also conformation from my side, removing the key with a È did help.

Richard Lamont schreef:
> I can confirm this. I deleted the one key on my keyring that contains
> non-Latin characters (a Chinese name with a .tw address) and now
> Enigmail's key management works again. Thanks to sbg and anke for the
> tip.
>
>

Revision history for this message
Max (mwiehle2) wrote : Re: Key management broken after Thunderbird upgrade

Installing the latest update of enigmail fixes it for me.

I ran
sudo thunderbird
to have write access to the plugin dirs and then
extra/extentions/update

updated enigmail to 0.94.4 or so for me which fixes the bug.

Would be nice if this was made available via apt.

Alexander Sack (asac)
description: updated
Changed in enigmail:
status: Confirmed → Triaged
Alexander Sack (asac)
Changed in enigmail:
status: Triaged → In Progress
Revision history for this message
Alexander Sack (asac) wrote :
Revision history for this message
Alexander Sack (asac) wrote :
Revision history for this message
Alexander Sack (asac) wrote :
Revision history for this message
Alexander Sack (asac) wrote :

... all three uploaded to -proposed.

Changed in enigmail:
importance: Undecided → High
Martin Pitt (pitti)
Changed in thunderbird:
status: New → Invalid
status: New → Invalid
status: New → Invalid
Revision history for this message
Martin Pitt (pitti) wrote :

Please make this bug conformant to https://wiki.ubuntu.com/StableReleaseUpdates. Wrt. the edgy patch, the changelog talks about "FTBFS in dapper". Is that still relevant for the edgy update?

Is this bug fixed in gutsy? How was it tested? This is quite a big patch, so it should be confirmed to be fixed and not causing regressions in gutsy.

Revision history for this message
Alexander Sack (asac) wrote :

Martin, I added the required infos to summary ... gutsy package isn't affected because it ships latest enigmail ... which doesn't have this problem.

The patch replaces the Unicode functions with the ones from latest enigmail. It was prepared by enigmail author and even released officially in 0.94.3 iirc.

description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

Alex claims this to be fixed in gutsy.

Changed in enigmail:
status: In Progress → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted to dapper-proposed.

Changed in enigmail:
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into feisty-proposed.

Changed in enigmail:
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

"Wrt. the edgy patch, the changelog talks about "FTBFS in dapper". Is that still relevant for the edgy update?"

Changed in enigmail:
status: New → Incomplete
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

Cleared on IRC, accepted into edgy-proposed.

Changed in enigmail:
status: Incomplete → Fix Committed
Revision history for this message
Alexander Sack (asac) wrote :

enigmail (2:0.94.2-0ubuntu2) feisty-proposed; urgency=low

  * SRU update for LP: #119038 - "MASTER Key management /
    Recipient Key Selection broken (endless loop in
    EnigConvertToUnicode):
    + 88_enigmail-fix-endless-loop-regression.dpatch:
      fix unicode functions EnigConvertGpgToUnicode and
      EnigConvertGpgToUnicode to not loop infinitely

 -- Alexander Sack <email address hidden> Mon, 30 Jul 2007 21:34:48 +0200

Changed in enigmail:
status: Fix Committed → Fix Released
Martin Pitt (pitti)
Changed in enigmail:
status: Fix Released → Fix Committed
Revision history for this message
Alexander Sack (asac) wrote :

enigmail (2:0.94.2-0ubuntu3) feisty-security; urgency=low

  * reupload to security. as this fixes a (thunderbird) regression
    that only affects security archive.

enigmail (2:0.94.2-0ubuntu2) feisty-proposed; urgency=low

  * SRU update for LP: #119038 - "MASTER Key management /
    Recipient Key Selection broken (endless loop in
    EnigConvertToUnicode):
    + 88_enigmail-fix-endless-loop-regression.dpatch:
      fix unicode functions EnigConvertGpgToUnicode and
      EnigConvertGpgToUnicode to not loop infinitely

 -- Alexander Sack <email address hidden> Tue, 28 Aug 2007 23:50:28 +0200

Changed in enigmail:
status: Fix Committed → Fix Released
Revision history for this message
Kees Cook (kees) wrote :

This has been published: http://www.ubuntu.com/usn/usn-469-2

Changed in enigmail:
assignee: nobody → asac
status: Fix Committed → Fix Released
assignee: nobody → asac
status: Fix Committed → Fix Released
assignee: nobody → asac
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.