Mir

android links to EGL extension functions directly

Bug #1189938 reported by Kevin DuBois
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Kevin DuBois
Mir 0.0.4

Bug Description

Android links to eglCreateImageKHR and eglTargetTexture2DOES directly instead of obtaining their function pointer address via eglGetProcAddress().

This in turn breaks the saucy/android build as detailed in bug 1190894.

See original description
Tags: android

Related branches

lp:~mir-team/mir/wip-1189938
lp:~kdub/mir/android-egl-extensions
Robert Carr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 1220 lines (+348/-258)
21 files modified
examples/demo_client_accelerated.cpp (+0/-3)
include/server/mir/graphics/egl_extensions.h (+43/-0)
include/test/mir_test_doubles/mock_egl.h (+4/-1)
include/test/mir_test_doubles/mock_gl.h (+0/-5)
src/server/graphics/CMakeLists.txt (+1/-0)
src/server/graphics/android/android_buffer_allocator.cpp (+5/-2)
src/server/graphics/android/android_graphic_buffer_allocator.h (+2/-0)
src/server/graphics/android/buffer.cpp (+10/-20)
src/server/graphics/android/buffer.h (+4/-3)
src/server/graphics/egl_extensions.cpp (+42/-0)
src/server/graphics/gbm/gbm_buffer_allocator.cpp (+4/-39)
src/server/graphics/gbm/gbm_buffer_allocator.h (+1/-2)
tests/mir_test_doubles/mock_egl.cpp (+38/-10)
tests/mir_test_doubles/mock_gl.cpp (+0/-9)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+2/-0)
tests/unit-tests/graphics/android/test_buffer.cpp (+10/-21)
tests/unit-tests/graphics/android/test_buffer_tex_bind.cpp (+105/-95)
tests/unit-tests/graphics/gbm/test_gbm_buffer.cpp (+1/-10)
tests/unit-tests/graphics/gbm/test_gbm_buffer_allocator.cpp (+0/-38)
tests/unit-tests/graphics/test_egl_extensions.cpp (+75/-0)
Daniel van Vugt (vanvugt)
Changed in mir:
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Even worse... saucy's /usr/lib/arm-linux-gnueabihf/libhybris-egl/libEGL.so.1
is missing the function eglCreateImageKHR

It only has eglDestroyImageKHR. Something is fishy and we can't cross-compile for saucy because of this...
Linking CXX shared library ../../lib/libmirserver.so
../../lib/libmirplatformgraphics.a(buffer.cpp.o): In function `mir::graphics::android::Buffer::bind_to_texture()':
/home/dan/bzr/mir/toy/src/server/graphics/android/buffer.cpp:93: undefined reference to `eglCreateImageKHR'

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The missing function eglCreateImageKHR is bug 1190894.

Changed in mir:
importance: High → Low
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This bug is low priority AFAIK. The available functions in any libEGL won't change very often. And if your code fails to build or execute then that's as good an error message as any.

Daniel van Vugt (vanvugt)
Changed in mir:
assignee: Kevin DuBois (kdub) → Daniel van Vugt (vanvugt)
importance: Low → High
status: Confirmed → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Linked a quick experimental branch so that the build completes. Unfortunately the resulting binaries don't work and many tests fail or hang.

description: updated
Daniel van Vugt (vanvugt)
Changed in mir:
importance: High → Undecided
Kevin DuBois (kdub)
Changed in mir:
importance: Undecided → High
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: Daniel van Vugt (vanvugt) → Kevin DuBois (kdub)
status: In Progress → Fix Committed
milestone: none → 0.0.4
Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.