Zorba

Update core module "full-text"

Bug #1189790 reported by Chris Hillery
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zorba
Fix Committed
High
Paul J. Lucas
Zorba 3.0 "Kratos"

Bug Description

Update core module "full-text". Refer to the Zorba 3.0 Module Update Checklist at http://my.zorba-xquery.com/dokuwiki/doku.php?id=module_update .

This minimally means renaming the module to the "http://zorba.io/modules/full-text" namespace, ensuring the documentation is accurate and up to standards, and moving the module contents out of unnecessary com/zorba-xquery/ subdirectories. The path for the module is currently modules/com/zorba-xquery/www/modules/full-text.xq .

Additional tasks for this module:
* Convert options arguments to JSON objects

See original description

Related branches

lp:~zorba-coders/zorba/bug-1189790
Matthias Brantner: Approve
Paul J. Lucas: Approve
Diff: 2764 lines (+605/-910)
85 files modified
ChangeLog (+1/-0)
modules/CMakeLists.txt (+1/-0)
modules/com/zorba-xquery/www/modules/CMakeLists.txt (+0/-7)
modules/com/zorba-xquery/www/modules/full-text.xsd (+0/-178)
modules/full-text/CMakeLists.txt (+20/-0)
modules/full-text/full-text.xq (+47/-50)
src/compiler/translator/translator.cpp (+0/-1)
src/context/static_context.cpp (+1/-1)
src/functions/CMakeLists.txt (+0/-4)
src/functions/func_ft_module_impl.cpp (+0/-166)
src/functions/func_ft_module_impl.h (+0/-120)
src/functions/function_consts.h (+0/-10)
src/functions/library.cpp (+0/-1)
src/functions/pregenerated/func_ft_module.cpp (+181/-19)
src/functions/pregenerated/func_ft_module.h (+64/-0)
src/functions/pregenerated/function_enum.h (+7/-0)
src/runtime/full_text/ft_module_impl.cpp (+111/-175)
src/runtime/full_text/ft_module_util.cpp (+0/-16)
src/runtime/full_text/ft_module_util.h (+0/-15)
src/runtime/full_text/pregenerated/ft_module.h (+0/-2)
src/runtime/spec/full_text/ft_module.xml (+38/-4)
src/runtime/spec/mappings.xml (+1/-1)
test/rbkt/ExpQueryResults/zorba/no-copy/test3.xml.res (+0/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-current-compare-options-1.xq (+8/-7)
test/rbkt/Queries/zorba/fulltext/ft-module-current-compare-options-2.xq (+7/-6)
test/rbkt/Queries/zorba/fulltext/ft-module-current-lang-true-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-da-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-de-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-en-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-es-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-fi-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-hu-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-it-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-nl-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-no-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-pt-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-ru-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-supported-false-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-supported-false-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stem-lang-sv-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-false-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-da-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-de-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-en-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-es-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-fi-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-fr-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-hu-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-it-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-nl-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-no-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-pt-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-supported-false-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-supported-false-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-lang-sv-supported-true.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-true-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-true-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-true-3.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-stop-word-true-4.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-thesaurus-lang-supported-false-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-thesaurus-lang-supported-false-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-thesaurus-lang-supported-false-3.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-thesaurus-lang-supported-true-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-is-thesaurus-lang-supported-true-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-stem-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-stem-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-stem-3.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-stem-4.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-strip-diacritics-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-3.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-4.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-5.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-thesaurus-lookup-6.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-node-1.xq (+15/-14)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-node-2.xq (+15/-14)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-node-3.xq (+4/-4)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-node-4.xq (+4/-4)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-nodes-1.xq (+11/-10)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-nodes-2.xq (+16/-15)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-string-1.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-module-tokenize-string-2.xq (+1/-1)
test/rbkt/Queries/zorba/fulltext/ft-thesaurus-FOCA0003-1.xq (+1/-1)
test/rbkt/Queries/zorba/no-copy/test3.xq (+0/-12)
Chris Hillery (ceejatec)
Changed in zorba:
assignee: nobody → Paul J. Lucas (paul-lucas)
importance: Undecided → High
milestone: none → 3.0
status: New → Confirmed
description: updated
tags: added: module-cleanup
summary: - This is my summary
+ Update core module "full-text"
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: Confirmed → In Progress
Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

The full-text module doesn't include any function that takes any kind of options argument. It does, however, RETURN options (or properties) that are XML elements. What should such functions return?

Revision history for this message
Chris Hillery (ceejatec) wrote :

I believe it should return a JSON object matching a JSON schema (which will need to be designed).

Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

And one specifies a JSON object by .... ?

    declare function ft:tokenize-node( $node as node() ) as XXX external;

What is the XXX?

Revision history for this message
Chris Hillery (ceejatec) wrote :

as object()

Unfortunately the decision was made to not (yet?) support JSON schema-specified object types, so there's nothing like object(ft:options). There's just object().

(Aside: if you're developing a pure JSONiq module, you can and should drop the parens and say "as object". But I think that's not appropriate for the full-text module.)

Paul J. Lucas (paul-lucas)
Changed in zorba:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.