Percona Server moved to https://jira.percona.com/projects/PS

Prepared statements are written to general query log after being executed

Bug #1182949 reported by Sergei Glushchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Server
Unknown
Unknown
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Medium
Unassigned
Percona Server moved to https://jira.percona.com/projects/PS 5.6.24-72.2
5.1
Won't Fix
Medium
Sergei Glushchenko
5.5
Fix Committed
Medium
Sergei Glushchenko
5.6
Fix Released
Medium
Unassigned
Percona Server moved to https://jira.percona.com/projects/PS 5.6.24-72.2

Bug Description

Prepared statements logged to general query log and audit plugin notified after statement being executed unlike most other log events which are written before query being executed.

Related branches

lp:~sergei.glushchenko/percona-server/5.1-ps-bug1182949
On hold for merging into lp:percona-server/5.1
Alexey Kopytov (community): Needs Information
Laurynas Biveinis (community): Needs Information
Diff: 53 lines (+18/-18)
1 file modified
Percona-Server/sql/sql_prepare.cc (+18/-18)
lp:~sergei.glushchenko/percona-server/5.5-ps-bug1182949
On hold for merging into lp:percona-server/5.5
Laurynas Biveinis (community): Needs Fixing
Alexey Kopytov: Pending requested
Diff: 105 lines (+55/-18)
4 files modified
Percona-Server/mysql-test/r/percona_bug1182949.result (+12/-0)
Percona-Server/mysql-test/t/percona_bug1182949-master.opt (+1/-0)
Percona-Server/mysql-test/t/percona_bug1182949.test (+24/-0)
Percona-Server/sql/sql_prepare.cc (+18/-18)
lp:~sergei.glushchenko/percona-server/5.6-ps-bug1182949
On hold for merging into lp:percona-server/5.6
Laurynas Biveinis (community): Needs Fixing
Alexey Kopytov: Pending requested
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Sergei -

This is an upstream bug, isn't? Can you link one here?

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

It seems that, for prepared statements, not only executing, but preparing is affected too.

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Preparing a client-side prepared statement is currently ignored by the scalability metrics plugin anyway (its current implementation only tracks COM_QUERY and COM_STMT_EXECUTE).

Also, as there's no audit plugin interface in 5.1, do we really want to fix this in 5.1?

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Preparing the statement can easily be tracked by scalability metrics plugin and I am going to implements this.
I agree that we can mark it as won't fix for 5.1. Does somebody has an objections?

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Upstream is fixed in 5.7, do we want to port the fix into 5.1/5.5/5.6 ?

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

https://github.com/percona/percona-server/pull/60

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1372

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.