Zero values causes "Invalid --set-vars value: var=0"
Bug #1182856 reported by
Przemek
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter | ||
Bug Description
When trying to assign 0 to any variable using --set-vars option, getting "Invalid --set-vars value" message, even before the tool tries to connect to MySQL and apply the value.
How to reproduce:
pt-online-
Invalid --set-vars value: SQL_LOG_BIN=0
The same using SQL_LOG_BIN=OFF or using any other value then 0 works.
I've tested on versions 2.2.1 and 2.2.2.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-set-vars-bug-1182856
- Daniel Nichter: Approve
-
Diff: 646 lines (+96/-54)28 files modifiedbin/pt-agent (+2/-2)
bin/pt-align (+2/-2)
bin/pt-archiver (+2/-2)
bin/pt-config-diff (+2/-2)
bin/pt-deadlock-logger (+2/-2)
bin/pt-diskstats (+2/-2)
bin/pt-duplicate-key-checker (+2/-2)
bin/pt-fifo-split (+2/-2)
bin/pt-find (+2/-2)
bin/pt-fingerprint (+2/-2)
bin/pt-fk-error-logger (+2/-2)
bin/pt-heartbeat (+2/-2)
bin/pt-index-usage (+2/-2)
bin/pt-kill (+2/-2)
bin/pt-online-schema-change (+2/-2)
bin/pt-query-digest (+2/-2)
bin/pt-show-grants (+2/-2)
bin/pt-slave-delay (+2/-2)
bin/pt-slave-find (+2/-2)
bin/pt-slave-restart (+2/-2)
bin/pt-table-checksum (+2/-2)
bin/pt-table-sync (+2/-2)
bin/pt-table-usage (+2/-2)
bin/pt-upgrade (+2/-2)
bin/pt-variable-advisor (+2/-2)
bin/pt-visual-explain (+2/-2)
lib/OptionParser.pm (+2/-2)
t/lib/OptionParser.t (+42/-0)
| Changed in percona-toolkit: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 2.2.4 |
| tags: |
added: all-tools removed: pt-online-schema-change |
| summary: |
- pt-online-schema-change - unable to use 0 in --set-vars + Zero values causes "Invalid --set-vars value: var=0" |
| Changed in percona-toolkit: | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/