"Edit QR code" and "Change the QR colors" icons missing

Thanks a lot for testing and for reporting this bug. This is really helpful.

For those buttons, we're using these standard GNOME symbolic icons:

- preferences-color-symbolic (/usr/share/icons/gnome/scalable/apps/preferences-color-symbolic.svg)
- edit-select-all-symbolic (/usr/share/icons/gnome/scalable/actions/edit-select-all-symbolic.svg)

It seems these were introduced in Ubuntu 12.10 [1] and are not available in Ubuntu 12.04.

We'll need to ship them in the Ubuntu 12.04 package.

[1] http://packages.ubuntu.com/search?suite=quantal&arch=any&mode=exactfilename&searchon=contents&keywords=preferences-color-symbolic.svg

I'm not sure how to actually load those images if they are not read from the system location (i.e. if we ship them ourselves as part of the package), as Glade doesn't seem to load .svg files as images for buttons.

As a stop-gap measure for Ubuntu 12.04 users, we could use non-symbolic icons. They will not be consistent, but it will be better than having no icon. E.g.

- For the edit color button: applications-painting
- For the invert button: object-inverse

Or to make life easier, we could just go for these icons for all Qreator versions.

OK, here is my solution:

- we copy the missing svg files into 'data/media'
- we add the following lines into e.g. 'qreator/__init__.py', somewhere close to the beginning:

icontheme = Gtk.IconTheme.get_default()
icontheme.append_search_path(os.path.join(get_data_path(), "media"))

Since I don't have 12.04 anywhere running, I tested this solution by using fantasy names for the icons and it worked.

I have added a branch that you can test:
lp:~stefan-schwarzburg/qreator/desktop_missing_icons

Feedback (especially from 12.04 users) would be much appreciated!

Excellent, thanks Stefan. That sounds like a sensible solution to me.

I've looked at and tested the branch and it looks good. Would you mind requesting a merge proposal so that we can get this merged? This way we'll get the packages created on the daily PPA, which we can then hand over to users as a direct link to a .deb file to install and test (I expect not many users might be able or interested to run directly from bzr).

Hi Stefan

2013/5/25 Schwarzburg <email address hidden>

> OK, here is my solution:
>
> - we copy the missing svg files into 'data/media'
> - we add the following lines into e.g. 'qreator/__init__.py', somewhere
> close to the beginning:
>
> icontheme = Gtk.IconTheme.get_default()
> icontheme.append_search_path(os.path.join(get_data_path(), "media"))
>
> Since I don't have 12.04 anywhere running, I tested this solution by
> using fantasy names for the icons and it worked.
>
> I have added a branch that you can test:
> lp:~stefan-schwarzburg/qreator/desktop_missing_icons
>
>
I did a "bzr branch" and started qreator from the bin directory. (I hope
that's the correct way to do it)

> Feedback (especially from 12.04 users) would be much appreciated!
>
>
On 12.04 I now have the icon available for the "Change the QR code colors"
but the "Edit QR code" icon is still missing.

I have also run the currently installed version (so 13.05.03) to verify the
two icons are still missing. (and they still are)

By the way (perhaps in response to David) the
        - edit-select-all-symbolic
(/usr/share/icons/gnome/scalable/actions/edit-select-all-symbolic.svg)
looks like the button I would call "Swap the foreground and background
colors" icon.
So, I was just wondering if this was supposed to be the same as the "Edit
QR code" icon. (sorry I don't quite know how to find the correct file names
in the code).

I've attached two images, the current (old) and the branch (new).

Best regards,
Folmer

> ** Changed in: qreator
> Assignee: (unassigned) => Schwarzburg (stefan-schwarzburg)
>
> ** Changed in: qreator
> Status: Triaged => In Progress
>
> ** Branch linked: lp:~stefan-schwarzburg/qreator/desktop_missing_icons
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1182766
>
> Title:
> "Edit QR code" and "Change the QR colors" icons missing
>
> Status in Qreator:
> In Progress
>
> Bug description:
> Ubuntu version 12.04 64-bit
> Qreator version 13.05.03
>
> Mentioned icons are missing from all QR-code generation options.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qreator/+bug/1182766/+subscriptions
>

--
Folmer Fredslund

Thanks Folmer. The screenshots are really useful.

I've now realized that the second icon that we are missing is 'text-editor-symbolic' instead of 'edit-select-all-symbolic'.

So we should be distributing 'text-editor-symbolic'.

Note: related to this bug, it seems that 'printer-symbolic' is not displaying well in Ubuntu 12.04: it seems not to be scaled correctly.

Thanks a lot Folmer, the screenshots are indeed very helpful!

Hi Stefan and David,

I can find the attached icon when I search for text-editor-symbolic.svg on
my system.
Is that the one you mean? Or was the name of the file changed perhaps?

I tried changing the name in the QreatorWindow.ui file and started Qreator,
which then gave me the icon, but I'm not sure it's the correct one ;-)

2013/5/27 Schwarzburg <email address hidden>

> Thanks a lot Folmer, the screenshots are indeed very helpful!
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1182766
>
> Title:
> "Edit QR code" and "Change the QR colors" icons missing
>
> Status in Qreator:
> In Progress
>
> Bug description:
> Ubuntu version 12.04 64-bit
> Qreator version 13.05.03
>
> Mentioned icons are missing from all QR-code generation options.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qreator/+bug/1182766/+subscriptions
>

--
Folmer Fredslund

I just tested the fix on 12.04

Here is the screenshot. So please disregard my previous comment about the missing svg files.

I hope this looks as expected!

Al 27/05/13 11:36, En/na Folmer Fredslund ha escrit:
> I just tested the fix on 12.04
>
> Here is the screenshot. So please disregard my previous comment about
> the missing svg files.
>
> I hope this looks as expected!
>
> ** Attachment added: "commit_173_on_ubuntu1204.png"
> https://bugs.launchpad.net/qreator/+bug/1182766/+attachment/3687750/+files/commit_173_on_ubuntu1204.png
>

That's indeed how it was supposed to look like. Thanks a lot for the
testing, it was extremely helpful!

Cheers,
David.