Segfault in LauncherIcon::TextureFromSpecificGtkTheme
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Critical
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Raring |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
==29781== Invalid read of size 1
==29781== at 0x8056C47: g_type_
==29781== by 0x16DFC154: unity::
==29781== by 0x16DFC450: unity::
==29781== by 0x16E12998: unity::
==29781== by 0x16F0568F: unity::
==29781== by 0x16DD9D89: unity::
==29781== by 0x18754831: nux::View:
==29781== by 0x1873820C: nux::Layout:
==29781== by 0x18713BB7: nux::BaseWindow
==29781== by 0x18754831: nux::View:
==29781== by 0x18758386: nux::WindowComp
==29781== by 0x1875F8EE: nux::WindowComp
==29781== Address 0x6168732f72737542 is not stack'd, malloc'd or (recently) free'd
==29781==
==29781==
==29781== Process terminating with default action of signal 11 (SIGSEGV)
==29781== General Protection Fault
==29781== at 0x8056C47: g_type_
==29781== by 0x16DFC154: unity::
==29781== by 0x16DFC450: unity::
==29781== by 0x16E12998: unity::
==29781== by 0x16F0568F: unity::
==29781== by 0x16DD9D89: unity::
==29781== by 0x18754831: nux::View:
==29781== by 0x1873820C: nux::Layout:
==29781== by 0x18713BB7: nux::BaseWindow
==29781== by 0x18754831: nux::View:
==29781== by 0x18758386: nux::WindowComp
==29781== by 0x1875F8EE: nux::WindowComp
GtkIconInfo * is released with g_object_unref, but its not actually a GObject. It should be released with gtk_icon_info_free
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Sam Spilsbury: Pending requested
- Ted Gould: Pending requested
-
Diff: 268 lines (+95/-9)10 files modifiedCMakeLists.txt (+8/-0)
config.h.cmake (+1/-0)
dash/ResultRenderer.cpp (+3/-1)
launcher/LauncherIcon.cpp (+4/-3)
launcher/MockLauncherIcon.h (+3/-0)
panel/PanelIndicatorEntryView.cpp (+2/-2)
tests/test_icon_loader.cpp (+27/-0)
tests/test_result_renderer.cpp (+2/-1)
unity-shared/GtkUtil.h (+43/-0)
unity-shared/IconLoader.cpp (+2/-2)
- Andrea Azzarone (community): Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 28 lines (+3/-3)1 file modifiedlauncher/LauncherIcon.cpp (+3/-3)
- PS Jenkins bot (community): Approve (continuous-integration)
- Sam Spilsbury (community): Approve
- Ted Gould (community): Approve
- Andrea Azzarone (community): Approve
-
Diff: 545 lines (+180/-61)11 files modifiedUnityCore/GLibWrapper.cpp (+5/-3)
UnityCore/GLibWrapper.h (+1/-4)
UnityCore/GTKWrapper.h (+79/-0)
dash/ResultRenderer.cpp (+13/-18)
launcher/LauncherIcon.cpp (+11/-17)
launcher/MockLauncherIcon.h (+2/-2)
panel/PanelIndicatorEntryView.cpp (+3/-5)
tests/CMakeLists.txt (+2/-1)
tests/test_gtk_wrapper.cpp (+54/-0)
tests/test_result_renderer.cpp (+5/-5)
unity-shared/IconLoader.cpp (+5/-6)
description: | updated |
Changed in unity: | |
status: | New → Incomplete |
status: | Incomplete → Confirmed |
assignee: | nobody → Sam Spilsbury (smspillaz) |
Changed in unity: | |
importance: | Undecided → Critical |
Changed in unity: | |
milestone: | none → 7.1.0 |
status: | Confirmed → In Progress |
assignee: | Sam Spilsbury (smspillaz) → Marco Trevisan (Treviño) (3v1n0) |
g_object_clear / g_object_unref is broken on < 3.8 and gtk_icon_info_free is deprecated on >= 3.8. I like it when libraries do this. We'll have to ifdef it.