Charmworld does not know about deleted/merged charms
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charmworld |
Fix Released
|
High
|
Abel Deuring | ||
Bug Description
Alice-irc was a promulgated charm. the charm was unpromulgated, then deleted from Lp. Since ingestion does not reconcile its collection with the charm store or with Lp, m.jc.com continues to show the last version of a charm it saw. In the case of alice-irc, m.jc.com claimed it was promulgate/
Consider the case where charms live for but a few days. The charm is forked, improved, then merged into the reviewed charm. From the VC perspective the branch has ended its life. The Charm is no longer of valuable since the value was transferred to long-lived reviewed charm.
At a minimum, ingestion needs to review/revise any charms in its collection that were not found during the phase to pull Lp branches. Ideally, ingest would reconcile with the charm store; ingest is duplicating what it thinks are the rules to enter the store.
Bug #1178497 is related; currently there is no way to list all charms present in the store.
Related branches
- Abel Deuring (community): Approve
- Aaron Bentley (community): Approve
-
Diff: 475 lines (+220/-37)8 files modifiedcharmworld/jobs/ingest.py (+6/-0)
charmworld/jobs/lp.py (+43/-17)
charmworld/jobs/tests/test_bzr.py (+33/-0)
charmworld/jobs/tests/test_ingest.py (+1/-0)
charmworld/jobs/tests/test_lp.py (+114/-19)
charmworld/jobs/tests/test_proof.py (+13/-0)
charmworld/models.py (+7/-0)
charmworld/testing/factory.py (+3/-1)
| summary: |
- Charmworld does not know about deleted charms + Charmworld does not know about deleted/merged charms |
| description: | updated |
| Aaron Bentley (abentley) wrote | #1 |
| Changed in charmworld: | |
| assignee: | nobody → Abel Deuring (adeuring) |
| status: | Triaged → In Progress |
| Changed in charmworld: | |
| status: | In Progress → Fix Committed |
| Changed in charmworld: | |
| status: | Fix Committed → Fix Released |
I think the "merged" scenario is an outlier, because the branch would need to be named "trunk" in order to enter the store in the first place. Such branches are rarely merged. But, the active trunk branch for a charm might be merged into a different series, daggy-fixes style. In that case, it would be bad to hide it simply because it had been merged.