[Calculator app] Can't add to existing equation once equals is entered

Bug #1179422 reported by Christina Li
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ubuntu Calculator App
Fix Released
Critical
Riccardo Padovani
Ubuntu UX
Fix Released
High
Christina Li

Bug Description

User can continue to add to the equation after equal signs is entered, rather than repeating the last operation.
Also, when continuing the equation any previous equal signs should be removed.

e.g
   3
+ 3
-----
= 9

If adding '1' to it, should appear as:
   3
+ 3
-----
    9
+ 1
-----
= 10

Related branches

Changed in ubuntu-ux:
assignee: nobody → Christina Li (christina-li)
importance: Undecided → High
Dalius (dalius-sandbox)
Changed in ubuntu-calculator-app:
assignee: nobody → Dalius Dobravolskas (dalius-sandbox)
Revision history for this message
Dalius (dalius-sandbox) wrote :

What to do with AC button? IMHO now we have inconsistent proposal.

Changed in ubuntu-calculator-app:
assignee: Dalius Dobravolskas (dalius-sandbox) → Riccardo Ferrazzo (f-riccardo87)
Revision history for this message
Christina Li (christina-li) wrote :

AC should always clear the whole equation, C only clears the last input including its operator.

Revision history for this message
Riccardo Ferrazzo (f-riccardo87) wrote :

But AC is showed when equals is pressed, then if an user can continue after equal is pressed what we have to do with AC? I have to turn it again into C?
Example:

3 C
 2 C
=5 AC <--- if i hide this equals sign do i need to show it again in case the user deletes everything under this point?
 1 C ?? <--- If the user presses C here only this line has to be cleared?
=6 AC ?? <--- AC here deletes everything or only from the nearest equal?
=??? <--- what happens if i press equals again here??? do i need to hide the previous equal signs? Do i need to remove this feature after being asked to implement it?

Changed in ubuntu-calculator-app:
status: New → In Progress
Revision history for this message
Christina Li (christina-li) wrote :

in the above example, the equation should looks as follows:

    3 c
+ 2 c
----------
= 5 AC --- keep the equals sign
+ 1 C ---yes, there's only one line to delete, but currently with 'C' user can only delete the last input anyway
----------
= 6 AC ----deletes everything as how normal 'AC' would

if you press equals again it should repeat the last operations, like in a traditional calculator, so in this example '+ 1'.

So basically, there's no need to remove the equals sign and we are building/continuing onto the existing equations.

And nope :) all your effort will be greatly appreciated!

Changed in ubuntu-ux:
status: New → Triaged
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Riccardo Ferrazzo (f-riccardo87)

Can we have any updates regarding this bug???

Mihir Soni (mihirsoni)
Changed in ubuntu-calculator-app:
importance: Undecided → Critical
Changed in ubuntu-ux:
status: Triaged → Fix Committed
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Please ensure you add/enhance the autopilot tests to test this progression once the work is complete.

Changed in ubuntu-calculator-app:
assignee: Riccardo Ferrazzo (f-riccardo87) → Riccardo Padovani (rpadovani)
summary: - [Calculator app] Can't add to existing equation once equals is entered
+ [Calculator app- July 2013] Can't add to existing equation once equals
+ is entered
tags: added: calculator-app-july-2013
summary: - [Calculator app- July 2013] Can't add to existing equation once equals
- is entered
+ [Calculator app] Can't add to existing equation once equals is entered
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-calculator-app at revision 141, scheduled for release in ubuntu-calculator-app, milestone alpha-1

Changed in ubuntu-calculator-app:
status: In Progress → Fix Committed
David Planella (dpm)
Changed in ubuntu-calculator-app:
milestone: none → alpha-1
milestone: alpha-1 → none
David Planella (dpm)
Changed in ubuntu-calculator-app:
milestone: none → coreapps-13.10-beta
David Planella (dpm)
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
Changed in ubuntu-calculator-app:
status: Fix Committed → Fix Released
Revision history for this message
John Lea (johnlea) wrote :

@dpm; hi, please do not change the status of bugs in the "ubuntu-ux" project, as we use this project to track design status and final design QA. For example, changing status from Fix Committed → Fix Released in ubuntu-ux means that a designer has tested the implementation of the bug on the phone and has confirmed that implementation matches the change request.

Full details of what status means for ubuntu-ux bugs is available at https://docs.google.com/a/canonical.com/document/d/1PcNRQZFbfmmQEvxu4SZHO3GZ9Zaetg9p2DOmRwOUbS0/edit#heading=h.yt7pgvf4mg7m

Reverting ubuntu-ux status back to Fix Committed so that designers know that the implementation is ready to test.

Changed in ubuntu-ux:
status: Fix Released → Fix Committed
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.