[needs-packaging] qreator

Here goes a quick review,

1) I don't see any reason that this should be a native package. You'd be better off using '3.0 quilt' for the debian/source/format

2) debian/changelog:
   - The upload target should be saucy
   - The version should be 13.05.1-0ubuntu1

2) debian/control:
   - software-center is listed twice in the Depends
   - The Standards-Version should be 3.9.4
   - Maintainer should be Ubuntu Developers <email address hidden>
     (see https://wiki.ubuntu.com/DebianMaintainerField)
   - You should probably drop the XB fields related to extras.
   - You might want to expand the description a bit.

3) It would be nice to have a debian/watch file even though you're upstream. See:
    http://developer.ubuntu.com/packaging/html/debian-dir-overview.html#the-watch-file

4) debian/copyright has a few minor issues:
   - You don't need to list "Copyright" multiple times in the same paragraph. (See example)
   - You should include a license snippet, not just a link to the common-licenses file. (See example)
   - See: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Files: *
Copyright: 1998 John Doe <email address hidden>
                     1998 Jane Smith <email address hidden>
License: GPL-2+
 This program is free software; you can redistribute it
 and/or modify it under the terms of the GNU General Public
 License as published by the Free Software Foundation; either
 version 2 of the License, or (at your option) any later
 version.
 .
 This program is distributed in the hope that it will be
 useful, but WITHOUT ANY WARRANTY; without even the implied
 warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
 PURPOSE. See the GNU General Public License for more
 details.
 .
 You should have received a copy of the GNU General Public
 License along with this package; if not, write to the Free
 Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 Boston, MA 02110-1301 USA
 .
 On Debian systems, the full text of the GNU General Public
 License version 2 can be found in the file
 `/usr/share/common-licenses/GPL-2'.

All in all, it's almost ready. It builds, installs, and runs great.

David, I'm unsubscribing sponsors, can you subscribe them back once you have addressed the review comments from Andrew?

Al 15/05/13 00:31, En/na Andrew Starr-Bochicchio ha escrit:
> Here goes a quick review,
>

Thanks a lot Andrew for the thorough review.

I've addressed all points and I've only got a question.

Updated .dsc file (for raring, see inline comment):
https://launchpad.net/~qreator-hackers/+archive/qreator-stable/+files/qreator_13.05.3-0ubuntu1.dsc

> 1) I don't see any reason that this should be a native package. You'd be
> better off using '3.0 quilt' for the debian/source/format
>

Ok. Done.

> 2) debian/changelog:
> - The upload target should be saucy

I'm currently on raring and the way I've been doing uploads to the PPA
is to create the raring source package, upload it there and then copy
the binaries across all other distro series in the PPA.

Therefore the upload target is still raring. Is there a way the uploader
can change the upload target? Or which workflow would you recommend for
me to create the saucy .dsc file and put it in a public place accessible
to ubuntu-sponsors?

Sorry if this is an obvious question, but my packaging experience is
limited.

> - The version should be 13.05.1-0ubuntu1
>

Done. Did a couple of upstream bugfix releases and updated the upstream
version too.

> 2) debian/control:
> - software-center is listed twice in the Depends
> - The Standards-Version should be 3.9.4
> - Maintainer should be Ubuntu Developers <email address hidden>
> (see https://wiki.ubuntu.com/DebianMaintainerField)
> - You should probably drop the XB fields related to extras.
> - You might want to expand the description a bit.
>

All done.

> 3) It would be nice to have a debian/watch file even though you're upstream. See:
> http://developer.ubuntu.com/packaging/html/debian-dir-overview.html#the-watch-file
>

Done.

> 4) debian/copyright has a few minor issues:
> - You don't need to list "Copyright" multiple times in the same paragraph. (See example)
> - You should include a license snippet, not just a link to the common-licenses file. (See example)
> - See: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
>

All done.

> Files: *
> Copyright: 1998 John Doe <email address hidden>
> 1998 Jane Smith <email address hidden>
> License: GPL-2+
> This program is free software; you can redistribute it
> and/or modify it under the terms of the GNU General Public
> License as published by the Free Software Foundation; either
> version 2 of the License, or (at your option) any later
> version.
> .
> This program is distributed in the hope that it will be
> useful, but WITHOUT ANY WARRANTY; without even the implied
> warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
> PURPOSE. See the GNU General Public License for more
> details.
> .
> You should have received a copy of the GNU General Public
> License along with this package; if not, write to the Free
> Software Foundation, Inc., 51 Franklin St, Fifth Floor,
> Boston, MA 02110-1301 USA
> .
> On Debian systems, the full text of the GNU General Public
> License version 2 can be found in the file
> `/usr/share/common-licenses/GPL-2'.
>
>
> All in all, it's almost ready. It build...

All is fine and in place when had a look except the watch file regex is not working

bhavani@bhavani-spagetti-monster:~/qreator/qreator-13.05.3$ uscan --verbose
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   https://launchpad.net/qreator/trunk/(.*)/+download/qreator-(.*).tar.gz
uscan warning: In watchfile debian/watch, reading webpage
  https://launchpad.net/qreator/trunk/trunk/+download/ failed: 404 Not Found
-- Scan finished

Regards,
Bhavani

I had to change the watch regex to look like this:

https://launchpad.net/qreator/+download https://launchpad.net/qreator/.*/qreator-(.+).tar.gz

due to:

https://bugs.launchpad.net/launchpad/+bug/231797

and its fine on my system

bhavani@bhavani-spagetti-monster:~/qreator/qreator-13.05.3$ uscan --report-status
Processing watchfile line for package qreator...
Newest version on remote site is 13.05.3, local version is 13.05.3
 => Package is up to date

Reviewing it for the final time before sponsoring

Regards
Bhavani

Thanks for the work David!

Uploaded. Sitting in new queue.

Regards
Bhavami

When you've worked out the issues with targeting Debian, feel free to get in touch if you need help navigating the waters over there and/or an upload sponsored...