Smoke and stem look bright at night
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Open Rails |
Fix Released
|
Medium
|
James Ross |
Bug Description
With OpenRails, the steam/smoke of steam and diesel engines keeps the same illumination/color at night. When it makes use of a white or grey color, then it looks bright at night. This is not very realistic. Like precipitations, it should become darker.
This can be fixed by using the same shading method as rain drops and snow flakes. SVN patch is attached.
Images before the change:
http://
http://
http://
http://
Images after the change:
http://
http://
http://
http://
Changed in or: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → 0.9 |
Changed in or: | |
milestone: | 0.9 → none |
Changed in or: | |
status: | Fix Committed → Fix Released |
Patch looks good - thanks!
Only tip I have is that "shader.LightVector = Viewer. World.Sky. solarDirection; " can probably go outside the loop, and maybe go as far up as SetState. that can be adjusted by the committer though, no need for a new patch.