We always do a restart on config change if we have persistent storage, even if we've set it to reload on config change

Bug #1175546 reported by Tom Haddon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
postgresql (Juju Charms Collection)
Fix Released
Undecided
Stuart Bishop

Bug Description

<mthaddon> so it seems there's something up with the DB shutting down intermittently
<mthaddon> https://pastebin.canonical.com/90372/
<mthaddon> trying to figure out what's going on there
<mthaddon> 2013-05-02 09:42:27,470: unit.hook.api@INFO: about reconfigure service with config_change_command = 'restart'
<gnuoy> mthaddon, I see entries in the charm.log on the pg server which tie in
<mthaddon> :)
<mthaddon> gnuoy: seems like we need to change that config value to do reloads
<gnuoy> yeah!
<mthaddon> that's weird, the default is reload
<gnuoy> mthaddon, shall I do that or are you doing it?
<mthaddon> gnuoy: taking a look now, will let you know before I change anything
<mthaddon> juju get cert-postgresql suggests it should be doing a reload, not a restart
<bigkevmcd> seems to be completing tasks again
<mthaddon> so I think this is a charm bug
<mthaddon> we do "if config_changed_volume_apply()" but this returns true even if the volume is already mounted and unchanged
<mthaddon> so we are basically always going to do a restart if we have a persistent storage volume

Related branches

Tom Haddon (mthaddon)
tags: added: canonical-webops
Revision history for this message
Stuart Bishop (stub) wrote :

config_change_command is no longer wired up to anything.

Restarting is happening automatically whenever postgresql.conf entries are changed that require it.

Other cases get a reload. Except for bits like this one, which IIRC already had a forced restart and I didn't want to change it.

Revision history for this message
Stuart Bishop (stub) wrote :

I think the forced restart was because postgreSQL may not be running at that point. However, the smarter postgresql_reload_or_restart() we are now using actually starts up PostgreSQL if it is not running, so I think we can simply not force the behavior and things will behave as intended.

Changed in postgresql (Juju Charms Collection):
status: New → In Progress
assignee: nobody → Stuart Bishop (stub)
Stuart Bishop (stub)
Changed in postgresql (Juju Charms Collection):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.