WAV recording: CUE sheet file is incorrect and misses first track in set

Bug #1169327 reported by Robb Bean
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Robb Bean
1.10
Won't Fix
Low
Unassigned
1.11
Fix Released
Low
Robb Bean

Bug Description

Cheers,

I'm using latest Mixxx 1.10.1 as installed from the Ubuntu/Mint repository. I appreciate the new WAV recording feature very much, so that Mixxx writes an appropriate CUE sheet file. Unfortunately there are two minor things that break up the CUE sheet:

1. The contents of TITLE and PERFORMER fields is not enclosed by quotes. If I read the "spec" correctly, they should be. E.g. playing a Mixxx generated CUE sheet in VLC player only gives the first words as artist resp. title. After manually correcting the file it worked as expected. A (really small) patch of 1.10.1's src/recording/enginerecord.cpp is attached.

2. If I first select a track to play and then start recording, the CUE sheet will loose this information. You can see it in the file, because TRACK 01 starts not at time offset 0:00:00. Looking around in line 201 and following of 1.10.1's src/recording/enginerecord.cpp, I guess that EngineRecord::metaDataHasChanged() returns false so the CUE sheet does not get updated (line 201 again), together with the counter m_cuetrack.

Yours and still having fun,
Robb

Related branches

Revision history for this message
Robb Bean (robb-bean) wrote :
RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Low
status: New → In Progress
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good. Thanks for the patch!

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I also fixed the unwritten first track issue in lp:mixxx/1.11 r3874.

Changed in mixxx:
assignee: nobody → Robb Bean (robb-bean)
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6987

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.