innobackupex uses SHOW MASTER STATUS to obtain binlog file and position

Bug #1168513 reported by George Ormond Lorch III
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
High
Alexey Kopytov
2.0
Invalid
Undecided
Unassigned
2.1
Fix Released
High
Alexey Kopytov

Bug Description

Tests performed against Percona Server 5.5 (revno 499).

In 2.0 (revno 528), innobackupex is calling SHOW MASTER STATUS in order to obtain the binlog filename and position. The server is not a master or a slave but a standalone that is not utilizing binary logs and as such returns an empty set for this command.

In 2.1 (revno 534), using DBD and "use warnings FATAL => 'all'" causes a Perl error in write_binlog_info after calling and assigning:
get_mysql_master_status($con); # calls SHOW MASTER STATUS
my $filename = $con->{master_status}->{File};
my $position = $con->{master_status}->{Position};

then attempting to use $filename:
Use of uninitialized value $filename in concatenation (.) or string at /data/bin/xb-2.1-PLMCE/innobackupex line 1338.

This causes innobackupex to terminate and leaves the xtrabackup process running (https://bugs.launchpad.net/bugs/1135441).

Related branches

description: updated
Revision history for this message
Alexey Kopytov (akopytov) wrote :

The problem is benign in 2.0, because $filename and $position are initialized to empty strings. So in the case when the server is not a master we just create an empty xtrabackup_binlog_info. I think we can keep that behavior for 2.0 (thus marking the bug report as Invalid). And for 2.1 we can change it to not create xtrabackup_binlog_info when binlog info is not available.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-356

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.