innobackupex uses SHOW MASTER STATUS to obtain binlog file and position
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
High
|
Alexey Kopytov | ||
2.0 |
Invalid
|
Undecided
|
Unassigned | ||
2.1 |
Fix Released
|
High
|
Alexey Kopytov |
Bug Description
Tests performed against Percona Server 5.5 (revno 499).
In 2.0 (revno 528), innobackupex is calling SHOW MASTER STATUS in order to obtain the binlog filename and position. The server is not a master or a slave but a standalone that is not utilizing binary logs and as such returns an empty set for this command.
In 2.1 (revno 534), using DBD and "use warnings FATAL => 'all'" causes a Perl error in write_binlog_info after calling and assigning:
get_mysql_
my $filename = $con->{
my $position = $con->{
then attempting to use $filename:
Use of uninitialized value $filename in concatenation (.) or string at /data/bin/
This causes innobackupex to terminate and leaves the xtrabackup process running (https:/
Related branches
- Laurynas Biveinis (community): Approve
- Registry Administrators: Pending requested
-
Diff: 38 lines (+23/-0)2 files modifiedinnobackupex (+5/-0)
test/t/bug1168513.sh (+18/-0)
description: | updated |
The problem is benign in 2.0, because $filename and $position are initialized to empty strings. So in the case when the server is not a master we just create an empty xtrabackup_ binlog_ info. I think we can keep that behavior for 2.0 (thus marking the bug report as Invalid). And for 2.1 we can change it to not create xtrabackup_ binlog_ info when binlog info is not available.