libindicator desktop shortcuts should create a GAppinfo from commandline

Bug #1168373 reported by Marco Trevisan (Treviño)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libindicator
Fix Committed
Low
Marco Trevisan (Treviño)
libindicator (Ubuntu)
Fix Released
Low
Marco Trevisan (Treviño)
Raring
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Use of a hack to generate shortcuts instead of the dedicated function.

[Test Case]

Not known, the hack seems to work but is not optimal.

[Regression Potential]

The code affected is the generation of indicator shortcuts.

---

We currently generate the GAppInfo to launch the shortcuts using an hack by generating a fake .desktop key-file in memory and then building an AppInfo from it. This is not needed, since g_app_info_create_from_commandline can do everything that we need.

Related branches

Changed in libindicator (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:libindicator at revision 491, scheduled for release in libindicator, milestone Unknown

Changed in libindicator:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:libindicator/13.04 at revision 488, scheduled for release in libindicator, milestone 13.04.1

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libindicator - 12.10.2daily13.06.07-0ubuntu1

---------------
libindicator (12.10.2daily13.06.07-0ubuntu1) saucy; urgency=low

  [ Ted Gould ]
  * Migrating away from deprecated gtk_icon_info_free().

  [ William Hua ]
  * Use GIcon's serialization/deserialization interface for indicator
    icons so that we can load icons as PNG data transmitted over the
    bus.

  [ Marco Trevisan (Treviño) ]
  * IndicatorDesktopShortcuts: Use the proper way to create an AppInfo
    from command-line Removed the hack that we used to create a .desktop
    app-info from a locally generated keyfile, using
    g_app_info_create_from_commandline instead. (LP: #1168373)
  * tests: fix compilation and make check.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 492
 -- Ubuntu daily release <email address hidden> Fri, 07 Jun 2013 02:02:37 +0000

Changed in libindicator (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Marco, or anyone else affected,

Accepted libindicator into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libindicator/12.10.2daily13.06.19~13.04-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libindicator (Ubuntu Raring):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote : [libindicator/raring] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for raring for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
tags: added: verification-done
removed: removal-candidate verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libindicator - 12.10.2daily13.06.19~13.04-0ubuntu1

---------------
libindicator (12.10.2daily13.06.19~13.04-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * IndicatorDesktopShortcuts: Use the proper way to create an AppInfo
    from command-line Removed the hack that we used to create a .desktop
    app-info from a locally generated keyfile, using
    g_app_info_create_from_commandline instead. (LP: #1168373)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 489 (bootstrap)
  * Automatic snapshot from revision 490
 -- Ubuntu daily release <email address hidden> Wed, 19 Jun 2013 02:02:32 +0000

Changed in libindicator (Ubuntu Raring):
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.