Mir

occasional segfault during client terminations

Bug #1168072 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Kevin DuBois
Mir 0.0.3

Bug Description

On my nexus4, if I repeatedly open and close (ctrl-c) a client, before about the 20th time I do this cycle, the server will segfault.
I also noticed a segfault in the acceptance test that appears to be related. I tracked this problem to BufferSwapperMulti::shutdown, which can sometimes have no buffer available during the shutdown.

Related branches

lp:~kdub/mir/fix-shutdown-bug
Daniel van Vugt: Approve
Alexandros Frantzis (community): Approve
Alan Griffiths: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 30 lines (+11/-1)
2 files modified
src/server/surfaces/surface.cpp (+0/-1)
tests/unit-tests/surfaces/test_surface.cpp (+11/-0)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sounds kind of like bug 1167163, no?

Changed in mir:
status: New → Incomplete
Kevin DuBois (kdub)
Changed in mir:
status: Incomplete → In Progress
Revision history for this message
Kevin DuBois (kdub) wrote :

Daniel, after looking at the backtrace in the other bug, it looks like its unrelated (at least at first glance). This backtrace would always go through BufferSwapperMulti's shutdown() function.

Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Kevin DuBois (kdub)
milestone: none → 0.0.3
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I wonder how opening/closing a client can lead to BufferSwapperMulti::shutdown(), which is called only during server shutdown (through shell->shutdown() in the DisplayServer destrutor). Perhaps an exception is thrown in the server for some other reason, and shutdown() is called while unwinding the stack?

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> I wonder how opening/closing a client can lead to BufferSwapperMulti::shutdown(), which is called only during server shutdown > (through shell->shutdown() in the DisplayServer destrutor). Perhaps an exception is thrown in the server for some other reason, > and shutdown() is called while unwinding the stack?

Ignore this... I just realized that shutdown() is also called when a ms::Surface is destroyed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 592, scheduled for release in mir, milestone 0.0.3

Changed in mir:
status: In Progress → Fix Committed
Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.