[Clock app] Clock app code style does not follow qml, javascript guidelines
Bug #1167040 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Clock App |
Fix Released
|
Low
|
Nekhelesh Ramananthan | ||
Bug Description
The current ubuntu-clock-app code trunk branch does not follow qml, javascript guidelines and standards which also include some of the code without any comments. This needs to be fixed for better readability in the future and bug fixing.
QML Code Style Guidelines can be found at http://
Javascript Guidelines can be found at http://
Related branches
lp:~nik90/ubuntu-clock-app/improve-code-style
- Renato Araujo Oliveira Filho (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Clock Developers: Pending requested
-
Diff: 1491 lines (+254/-408)19 files modifiedalarm/AlarmPage.qml (+13/-6)
clock/ClockPage.qml (+6/-5)
common/AnalogClockFace.qml (+9/-11)
common/AnalogClockHand.qml (+6/-10)
common/AnalogClockMarker.qml (+5/-7)
common/AnalogFaceBase.qml (+8/-9)
common/AnalogGlowEffect.qml (+2/-1)
common/AnalogHand.qml (+6/-13)
common/ClockUtils.js (+5/-5)
common/Constants.js (+13/-13)
common/Storage.qml (+3/-3)
debian/changelog (+19/-1)
stopwatch/HandGradient.qml (+5/-15)
stopwatch/StopwatchPage.qml (+64/-164)
stopwatch/StopwatchScript.js (+17/-16)
timer/TimerPage.qml (+44/-107)
timer/TimerScript.js (+13/-14)
timer/TimerStorage.qml (+5/-5)
ubuntu-clock-app.qml (+11/-3)
| Changed in ubuntu-clock-app: | |
| status: | New → In Progress |
| assignee: | nobody → Nekhelesh Ramananthan (nik90) |
| importance: | Undecided → Low |
| milestone: | none → alpha-1 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
| summary: |
- Clock app code style does not follow qml, javascript guidelines + [Clock app] Clock app code style does not follow qml, javascript + guidelines |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-clock-app at revision 29, scheduled for release in ubuntu-clock-app, milestone alpha-1