test_server_monkey_patch leaves orphaned process

Bug #1158247 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
John Bresnahan
Grizzly
Fix Released
Medium
John Bresnahan
glance (Ubuntu)
Fix Released
Medium
Unassigned
Raring
Fix Released
Medium
Unassigned

Bug Description

When running the test_server_monkey_patch test against distro packages in Ubuntu raring, a python process gets left running; this causes issue in the official distro builders as that process still has an open handle, causing the build to spin and hit timeouts:

jamespage@hendrix:~/src/ubuntu/thelab/daily-fixes/glance$ ./run_tests.sh -N -P glance.tests.functional.test_server_monkey_patch
glance.tests.functional.test_server_monkey_patch.TestClientServerInteractions.test_time_is_monkey_patched ... ok

----------------------------------------------------------------------
Ran 1 test in 1.045s

OK
jamespage@hendrix:~/src/ubuntu/thelab/daily-fixes/glance$ ps -ef | grep nose
1000 18305 1 0 11:20 pts/5 00:00:00 /usr/bin/python /usr/bin/nosetests glance.tests.functional.test_server_monkey_patch
1000 18307 5321 0 11:20 pts/5 00:00:00 grep --color=auto nose

I see exactly the same when running the test using venv against master:

jamespage@hendrix:~/src/upstream/glance$ ./run_tests.sh glance.tests.functional.test_server_monkey_patch
glance.tests.functional.test_server_monkey_patch.TestClientServerInteractions.test_time_is_monkey_patched ... ok

----------------------------------------------------------------------
Ran 1 test in 1.066s

OK
jamespage@hendrix:~/src/upstream/glance$ ps -aef | grep nose
1000 20145 1 0 11:30 pts/5 00:00:00 /usr/bin/python /usr/bin/nosetests glance.tests.functional.test_server_monkey_patch
1000 20147 5321 0 11:30 pts/5 00:00:00 grep --color=auto nose

Related branches

James Page (james-page)
Changed in glance (Ubuntu Raring):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24997

Changed in glance:
assignee: nobody → Chuck Short (zulcss)
status: New → In Progress
Revision history for this message
Mark Washenberger (markwash) wrote :

Hi Chuck,

Sorry this recent addition broke things for you. I think we should just remove this test. Maybe it would help you too if we backport the test removal to grizzly?

Thanks

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/25107

Changed in glance:
assignee: Chuck Short (zulcss) → Mark Washenberger (markwash)
Revision history for this message
James Page (james-page) wrote :

Mark - backport to grizzly would be great (one less patch to carry for Ubuntu :-))

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glance - 1:2013.1~rc1-0ubuntu2

---------------
glance (1:2013.1~rc1-0ubuntu2) raring; urgency=low

  * debian/patches/fix-ubuntu-tests.patch: Add configuration change
    to allow testsuite to finish on Ubuntu buildds. (LP: #1158247)
 -- Chuck Short <email address hidden> Fri, 22 Mar 2013 10:55:03 -0500

Changed in glance (Ubuntu Raring):
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/25188

Changed in glance:
assignee: Mark Washenberger (markwash) → John Bresnahan (jbresnah)
tags: added: grizzly-rc-potential
Changed in glance:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in glance:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/25188
Committed: http://github.com/openstack/glance/commit/2ff8b9627c9c9a48af0e12b65bbbe4325d5e804c
Submitter: Jenkins
Branch: master

commit 2ff8b9627c9c9a48af0e12b65bbbe4325d5e804c
Author: John Bresnahan <email address hidden>
Date: Fri Mar 22 11:26:12 2013 -1000

    Directly verifying that time and socket are monkey patched

    This tests makes sure that thew wsgi object properly monkey patched
    two needed modules, socket and time. In bug 988099 it was noted that
    the time module was not being monkey patched. A test was added that
    unfortunately introduced a bug and a patch to revert it is here:
    https://review.openstack.org/#/c/25107/ in order to fix bug 1158247.
    This patch allows for test_server_monkey_patch.py to be removed
    without losing the verification of that functionality.

    Fixes bug 1158247
    Change-Id: I8da6b04d0cc0dae00ba52e5b7350a5e01a76cadb

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25635

Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/25635
Committed: http://github.com/openstack/glance/commit/13f8f0082faf70debb3c56e01e7492f29913e783
Submitter: Jenkins
Branch: milestone-proposed

commit 13f8f0082faf70debb3c56e01e7492f29913e783
Author: John Bresnahan <email address hidden>
Date: Fri Mar 22 11:26:12 2013 -1000

    Directly verifying that time and socket are monkey patched

    This tests makes sure that thew wsgi object properly monkey patched
    two needed modules, socket and time. In bug 988099 it was noted that
    the time module was not being monkey patched. A test was added that
    unfortunately introduced a bug and a patch to revert it is here:
    https://review.openstack.org/#/c/25107/ in order to fix bug 1158247.
    This patch allows for test_server_monkey_patch.py to be removed
    without losing the verification of that functionality.

    Fixes bug 1158247
    Change-Id: I8da6b04d0cc0dae00ba52e5b7350a5e01a76cadb

Changed in glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.