Percona XtraBackup moved to https://jira.percona.com/projects/PXB

dict_sys_tables_get_flags() in compact.cc redundant

Bug #1156195 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Low
Laurynas Biveinis
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 2.1.0-beta1 "Chaubanagogum"
2.0
Invalid
Undecided
Unassigned
2.1
Fix Released
Low
Laurynas Biveinis
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 2.1.0-beta1 "Chaubanagogum"

Bug Description

InnoDB has dict_sys_tables_get_flags() that is almost identical and is called from dict_check_tablespaces_and_store_max_id() and dict_load_table[_low]() for versions 5.1 plugin - 5.6, thus InnoDB already performs the same validation for the tables being loaded and dict_sys_tables_get_flags() can be harmlessly removed.

Related branches

lp:~laurynas-biveinis/percona-xtrabackup/BT-28340-2.1
Alexey Kopytov (community): Approve
Stewart Smith (community): Approve
Diff: 3963 lines (+2134/-415)
19 files modified
BUILD.txt (+1/-0)
patches/innodb56.patch (+974/-0)
src/Makefile (+28/-3)
src/compact.cc (+102/-111)
src/ds_encrypt.c (+3/-4)
src/fil_cur.cc (+6/-11)
src/fil_cur.h (+2/-2)
src/innodb_int.cc (+243/-17)
src/innodb_int.h (+473/-41)
src/write_filt.cc (+2/-2)
src/xbcrypt_common.c (+0/-1)
src/xtrabackup.cc (+233/-198)
src/xtrabackup.h (+6/-6)
test/bootstrap.sh (+6/-1)
test/inc/common.sh (+2/-2)
test/t/bug1062684.sh (+4/-3)
test/t/bug891496.sh (+1/-0)
test/testrun.sh (+12/-2)
utils/build.sh (+36/-11)
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-869

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.