fn:nilled failures (at least 23)
Bug #1147563 reported by
Sorin Marian Nasoi
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zorba |
Fix Released
|
High
|
Cezar Andrei |
Bug Description
There are at least 15 failures in "fn-nilled" test set:
"cbcl-nilled-
Related branches
lp:~zorba-coders/zorba/bug1147563
- Sorin Marian Nasoi: Approve
- Chris Hillery: Approve
- Markos Zaharioudakis: Approve
- Cezar Andrei: Approve
-
Diff: 1714 lines (+471/-337)24 files modifiedChangeLog (+2/-0)
src/compiler/translator/translator.cpp (+4/-2)
src/runtime/accessors/accessors_impl.cpp (+10/-2)
src/runtime/core/path_iterators.cpp (+2/-2)
src/runtime/core/sequencetypes.cpp (+1/-1)
src/runtime/visitors/printer_visitor_impl.cpp (+19/-15)
src/store/api/item.h (+1/-1)
src/store/naive/item.cpp (+1/-1)
src/store/naive/node_items.cpp (+26/-24)
src/store/naive/node_items.h (+1/-7)
src/types/root_typemanager.cpp (+3/-0)
src/types/schema/schema.cpp (+85/-80)
src/types/schema/schema.h (+24/-21)
src/types/schema/validate.cpp (+16/-12)
src/types/typeimpl.cpp (+181/-88)
src/types/typeimpl.h (+24/-17)
src/types/typemanager.h (+4/-3)
src/types/typemanagerimpl.cpp (+14/-8)
src/types/typemanagerimpl.h (+4/-3)
src/types/typeops.cpp (+26/-14)
test/fots/CMakeLists.txt (+16/-31)
test/rbkt/Queries/zorba/schemas/books.xsd (+2/-2)
test/update/Scripts/Readme.txt (+2/-3)
test/update/updtestdriver.cpp (+3/-0)
Changed in zorba: | |
milestone: | none → 2.9 |
importance: | Undecided → High |
tags: | added: hotlist |
Changed in zorba: | |
status: | New → In Progress |
summary: |
- FOTS: fn:nilled failures (at least 15) + fn:nilled failures (at least 15) |
tags: | added: function-library |
Changed in zorba: | |
assignee: | Juan Zacarias (juan457) → Markos Zaharioudakis (markos-za) |
Changed in zorba: | |
assignee: | Markos Zaharioudakis (markos-za) → Cezar Andrei (cezar-andrei) |
Changed in zorba: | |
status: | In Progress → Fix Committed |
Changed in zorba: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The implementation of nilled was wrong it always returned false.
So I fixed it, but now different tests fail, the thing with this now failing tests is that.
when you send the query
fn:nilled(<a xsi:nil="true" />) should return false but it returns true
zorba auto assigns xsi prefix to the namespace "http:// www.w3. org/2001/ XMLSchema- instance" and also it validates it automatically, I don't know if this is intended.
But without considering that it should return false because 1) The namespace is never specified (unless auto assigning xsi to the namespace "http:// www.w3. org/2001/ XMLSchema- instance" is intended) and/or 2) because is not validated against a schema
Any idea of what zorba do in an automatic way, and is there a way to turn it off for testing?