Parse error in percona-server.spec (RHEL5)

Bug #1144777 reported by Ignacio Nin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Invalid
Undecided
Unassigned
5.1
Invalid
Undecided
Unassigned
5.5
Fix Released
Critical
Ignacio Nin
5.6
Invalid
Undecided
Unassigned

Bug Description

percona-server.spec contains code that CentOS 5 rpmbuild(1) considers a parse error (output below). As a result it's not possible to build PS RPM's in CentOS 5. Relevant code:

Provides: mysql-server
#
%if %{rhel}
BuildRequires: pam-devel
%endif
#
BuildRequires: %{distro_buildreq}

This was introduced in revno 419. BuildRequires need to be consolidated.

$ sh ~/percona-server/build/build-rpm.sh --nosign --quiet work/
rm -rf Percona-Server-5.5.28-rel29.3-release Percona-Server-5.5.28-rel29.3-debug
Prepare Percona Server sources
rm -rf Percona-Server-5.5.28-rel29.3 Percona-Server-5.5.28
ln -s Percona-Server Percona-Server-5.5.28-rel29.3
ln -s Percona-Server Percona-Server-5.5.28
cp -R HandlerSocket-Plugin-for-MySQL Percona-Server-5.5.28-rel29.3/storage
patch -p1 -d Percona-Server-5.5.28-rel29.3/storage < handlersocket.patch
patching file HandlerSocket-Plugin-for-MySQL/configure.ac
cp -R UDF "Percona-Server-5.5.28-rel29.3"
cd "Percona-Server-5.5.28-rel29.3"/UDF && autoreconf --install
Using `AC_PROG_RANLIB' is rendered obsolete by `AC_PROG_LIBTOOL'
libtoolize: `config.guess' exists: use `--force' to overwrite
libtoolize: `config.sub' exists: use `--force' to overwrite
libtoolize: `ltmain.sh' exists: use `--force' to overwrite
Installing license files
install -m 644 COPYING.* Percona-Server-5.5.28-rel29.3

Percona Server source code is ready
Now change directory to Percona-Server-5.5.28-rel29.3 define variables as show below

export CFLAGS="-O2 -g -fmessage-length=0 -D_FORTIFY_SOURCE=2"
export CXXFLAGS="-O2 -g -fmessage-length=0 -D_FORTIFY_SOURCE=2"
export LIBS=-lrt

and run cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_CONFIG=mysql_release -DFEATURE_SET=community -DWITH_EMBEDDED_SERVER=OFF && make all install

error: parse error in expression
error: /home/buildbot/percona-server/build/percona-server.spec:236: parseExpressionBoolean returns -1
error: Package has no %description: Percona-Server-55

Tags: pkg
description: updated
Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

It would seem that some values of the %{rhel} macro could trigger this error -- trying avoiding it and using pam-devel as a consolidated requirement since we are building with PAM anyway.

Revision history for this message
Alexey Bychko (abychko) wrote :

ok. btw - yum install buildsys-macros on centos5 can help

Changed in percona-server:
status: New → Fix Committed
Stewart Smith (stewart)
Changed in percona-server:
milestone: 5.5.30-30.1 → 5.5.30-30.2
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Is this already merged? Here is what I see in checkout of current
5.5.30.2 HEAD:

-----------------------------------

License: Copyright (c) 2000, 2010, %{mysql_vendor}. All rights reserved. Use is subject to license terms. Under %{license_type} license as shown in the Description field.
Source: http://www.percona.com/downloads/Percona-Server-5.5/Percona-Server-%{mysql_version}-%{majorversion}.%{minorversion}/source/%{src_dir}.tar.gz
URL: http://www.percona.com/
Packager: Percona MySQL Development Team <email address hidden>
Vendor: %{percona_server_vendor}
Provides: mysql-server
BuildRequires: %{distro_buildreq} pam-devel

# Think about what you use here since the first step is to
# run a rm -rf
BuildRoot: %{_tmppath}/%{name}-%{version}-build

--------------------------------------------

Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

Merged in revno 470.

Revision history for this message
Alexey Kopytov (akopytov) wrote :
Changed in percona-server:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2904

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.