hr_payroll - missing & (and) on get_contract

Bug #1132963 reported by Mario Arias
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP R&D Addons Team 3
OpenERP Community Backports (Addons)
Status tracked in 7.0
6.1
Fix Released
Low
Mario Arias
7.0
Fix Released
Low
Mario Arias

Bug Description

Hi

Function get_contract on rh_payroll/rh_payroll.py is missing an & (and) when checking for a valid contract.

line 383 shoould changre from:
        clause_3 = [('date_start','<=', date_from),'|',('date_end', '=', False),('date_end','>=', date_to)]

to
        clause_3 = ['&',('date_start','<=', date_from),'|',('date_end', '=', False),('date_end','>=', date_to)]

If not, clause_final will be incorrect and will fail for contracts that end during the given period.

Tags: hr payroll

Related branches

Changed in openobject-addons:
status: New → Confirmed
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
sunil prajapati(OpenERP Trainee) (sunil.prajapati-openerp) wrote :

 It has been fix committed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1132963-sunil

  Revision No: 8593.
  Revision ID:<email address hidden>

Thanks,
sunil prajapati

Changed in openobject-addons:
status: In Progress → Fix Committed
tags: added: hr payroll
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.