OpenStack Dashboard (Horizon)

"SyntaxError: invalid increment operand" when parsing JavaScript using Firefox

Bug #1130610 reported by Nerijus Bendziunas on 2013-02-20

This bug affects 5 people

	Status	Importance	Assigned to
OpenStack Dashboard (Horizon)	Invalid	Undecided	David Lyle
horizon (Ubuntu)	Fix Released	High	James Page
Raring	Fix Released	High	James Page
python-django-compressor (Ubuntu)	Fix Released	High	James Page
Raring	Fix Released	High	James Page

Bug Description

OS: Ubuntu 12.04
Packages: Ubuntu grizzly testing
Browser: FireFox 19

When loading JavaScript code FireFox getting this error:
SyntaxError: invalid increment operand
https://X.Y.Z.W/static/dashboard/js/57c506ad41ce.js
Line 99
...ch(function(){this.id||(this.id="ui-id-"+++n)})},removeUniqueId:function(){retur...

Error apears after logging into dashboard. In Chrome 24 all works correct.

Little bit of investinagion:
horizon/static/horizon/lib/jquery/jquery-ui-1.9.2.custom.min.js has '(this.id="ui-id-"+ ++n)})' and after compression it becames '(this.id="ui-id-"+++n)})'

Related branches

lp:~james-page/horizon/grizzly-rc1

Merged into lp:~openstack-ubuntu-testing/horizon/grizzly at revision 146

Yolanda Robla (community): Approve on 2013-03-20

lp:ubuntu/raring-proposed/python-django-compressor

lp:~openstack-ubuntu-testing/horizon/grizzly

lp:ubuntu/raring-proposed/horizon

lp:~openstack-ubuntu-testing/horizon/precise-grizzly

Victoria Martinez de la Cruz (vkmc) on 2013-02-22

Changed in horizon:
status:	New → Incomplete

Revision history for this message

Victoria Martinez de la Cruz (vkmc) wrote on 2013-02-22:

I'm using last DevStack version on Ubuntu 12.04 LTS and Firefox 19.0.

I tried to reproduce it in my local environment but I didn't that error.

How did you setted it up? Are you using Devstack or you downloaded the package from Ubuntu repos?

Thanks

Revision history for this message

Nerijus Bendziunas (nerijus-bendziunas) wrote on 2013-02-25:

Download full text (7.7 KiB)

I'm using thiese repos:
deb http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-build-depends/ubuntu precise main
deb-src http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-build-depends/ubuntu precise main
deb http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-trunk-testing/ubuntu precise main
deb-src http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-trunk-testing/ubuntu precise main

How to reproduce:
# apt-get update
# apt-get dist-upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
# apt-get install openstack-dashboard
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following extra packages will be installed:
  openstack-dashboard-ubuntu-theme python-appconf python-cloudfiles python-compressor python-django python-django-horizon python-openstack-auth
Suggested packages:
  python-psycopg2 python-psycopg python-flup python-sqlite geoip-database-contrib
The following NEW packages will be installed:
  openstack-dashboard openstack-dashboard-ubuntu-theme python-appconf python-cloudfiles python-compressor python-django python-django-horizon python-openstack-auth
0 upgraded, 8 newly installed, 0 to remove and 0 not upgraded.
Need to get 20.6 kB/6,567 kB of archives.
After this operation, 49.8 MB of additional disk space will be used.
Do you want to continue [Y/n]? y
Get:1 http://us.archive.ubuntu.com/ubuntu/ precise/main python-cloudfiles all 1.7.9.2-1 [20.6 kB]
Fetched 20.6 kB in 0s (49.6 kB/s)
Selecting previously unselected package python-cloudfiles.
(Reading database ... 388427 files and directories currently installed.)
Unpacking python-cloudfiles (from .../python-cloudfiles_1.7.9.2-1_all.deb) ...
Selecting previously unselected package python-django.
Unpacking python-django (from .../python-django_1.4.1-2~cloud0_all.deb) ...
Selecting previously unselected package python-appconf.
Unpacking python-appconf (from .../python-appconf_0.5-0ubuntu2~cloud0_all.deb) ...
Selecting previously unselected package python-compressor.
Unpacking python-compressor (from .../python-compressor_1.1.2-0ubuntu5~cloud0_all.deb) ...
Selecting previously unselected package python-openstack-auth.
Unpacking python-openstack-auth (from .../python-openstack-auth_1.0.1-0ubuntu6~precise_all.deb) ...
Selecting previously unselected package python-django-horizon.
Unpacking python-django-horizon (from .../python-django-horizon_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Selecting previously unselected package openstack-dashboard.
Unpacking openstack-dashboard (from .../openstack-dashboard_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Selecting previously unselected package openstack-dashboard-ubuntu-theme.
Unpacking openstack-dashboard-ubuntu-theme (from .../openstack-dashboard-ubuntu-theme_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Processing triggers for man-db ...
Setting up python-cloudfiles (1.7.9.2-1) ...
Setting up python-django (1.4.1-2~cloud0) ...
Setting up python...

I'm using  thiese repos:
deb http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-build-depends/ubuntu precise main
deb-src http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-build-depends/ubuntu precise main
deb http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-trunk-testing/ubuntu precise main
deb-src http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-trunk-testing/ubuntu precise main

How to reproduce:
# apt-get update
# apt-get dist-upgrade 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
# apt-get install openstack-dashboard
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following extra packages will be installed:
  openstack-dashboard-ubuntu-theme python-appconf python-cloudfiles python-compressor python-django python-django-horizon python-openstack-auth
Suggested packages:
  python-psycopg2 python-psycopg python-flup python-sqlite geoip-database-contrib
The following NEW packages will be installed:
  openstack-dashboard openstack-dashboard-ubuntu-theme python-appconf python-cloudfiles python-compressor python-django python-django-horizon python-openstack-auth
0 upgraded, 8 newly installed, 0 to remove and 0 not upgraded.
Need to get 20.6 kB/6,567 kB of archives.
After this operation, 49.8 MB of additional disk space will be used.
Do you want to continue [Y/n]? y
Get:1 http://us.archive.ubuntu.com/ubuntu/ precise/main python-cloudfiles all 1.7.9.2-1 [20.6 kB]
Fetched 20.6 kB in 0s (49.6 kB/s)            
Selecting previously unselected package python-cloudfiles.
(Reading database ... 388427 files and directories currently installed.)
Unpacking python-cloudfiles (from .../python-cloudfiles_1.7.9.2-1_all.deb) ...
Selecting previously unselected package python-django.
Unpacking python-django (from .../python-django_1.4.1-2~cloud0_all.deb) ...
Selecting previously unselected package python-appconf.
Unpacking python-appconf (from .../python-appconf_0.5-0ubuntu2~cloud0_all.deb) ...
Selecting previously unselected package python-compressor.
Unpacking python-compressor (from .../python-compressor_1.1.2-0ubuntu5~cloud0_all.deb) ...
Selecting previously unselected package python-openstack-auth.
Unpacking python-openstack-auth (from .../python-openstack-auth_1.0.1-0ubuntu6~precise_all.deb) ...
Selecting previously unselected package python-django-horizon.
Unpacking python-django-horizon (from .../python-django-horizon_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Selecting previously unselected package openstack-dashboard.
Unpacking openstack-dashboard (from .../openstack-dashboard_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Selecting previously unselected package openstack-dashboard-ubuntu-theme.
Unpacking openstack-dashboard-ubuntu-theme (from .../openstack-dashboard-ubuntu-theme_2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1_all.deb) ...
Processing triggers for man-db ...
Setting up python-cloudfiles (1.7.9.2-1) ...
Setting up python-django (1.4.1-2~cloud0) ...
Setting up python-appconf (0.5-0ubuntu2~cloud0) ...
Setting up python-compressor (1.1.2-0ubuntu5~cloud0) ...
Setting up python-openstack-auth (1.0.1-0ubuntu6~precise) ...
Setting up python-django-horizon (2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1) ...
Setting up openstack-dashboard (2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1) ...
 * Reloading web server config apache2                                                                                                                                                                                                                                 [ OK ] 
Setting up openstack-dashboard-ubuntu-theme (2013.1.a113.g7d13abc+git201302200401~precise-0ubuntu1) ...
 * Reloading web server config apache2                                                                                                                                                                                                                                 [ OK ]

When I trying load on broweser I'm getting 500 with error:
[Mon Feb 25 10:06:49 2013] [error] [client x.y.z.w]     raise OfflineGenerationError('You have offline compression enabled but key "%s" is missing from offline manifest. You may need to run "python manage.py compress".' % key)
[Mon Feb 25 10:06:49 2013] [error] [client x.y.z.w] OfflineGenerationError: You have offline compression enabled but key "f73af4bb410b7899592afadd8af2bf16" is missing from offline manifest. You may need to run "python manage.py compress"

# cd /usr/share/openstack-dashboard
# python manage.py compress 
Found 'compress' tags in:
	/usr/share/openstack-dashboard/openstack_dashboard/templates/_stylesheets.html
	/usr/lib/python2.7/dist-packages/horizon/templates/horizon/_conf.html
	/usr/lib/python2.7/dist-packages/horizon/templates/horizon/_scripts.html
Compressing... done
Compressed 3 block(s) from 3 template(s).

Now I can log in but Firebug showing to me "SyntaxError: invalid increment operand" error.

# cat /etc/openstack-dashboard/local_settings.py | grep -v '^\s*#'  | grep -v '^$'
import os
from django.utils.translation import ugettext_lazy as _
from openstack_dashboard import exceptions
DEBUG = False
TEMPLATE_DEBUG = DEBUG
HORIZON_CONFIG = {
    'dashboards': ('project', 'admin', 'settings',),
    'default_dashboard': 'project',
    'user_home': 'openstack_dashboard.views.get_user_home',
    'ajax_queue_limit': 10,
    'help_url': "http://docs.openstack.org",
    'exceptions': {'recoverable': exceptions.RECOVERABLE,
                   'not_found': exceptions.NOT_FOUND,
                   'unauthorized': exceptions.UNAUTHORIZED},
}
LOCAL_PATH = os.path.dirname(os.path.abspath(__file__))
CACHE_BACKEND = 'memcached://127.0.0.1:11211'
EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
try:
    from ubuntu_theme import *
except ImportError:
    pass
LOGIN_URL='/horizon/auth/login/'
LOGIN_REDIRECT_URL='/horizon'
COMPRESS_OFFLINE = True
OPENSTACK_HOST = "127.0.0.1"
OPENSTACK_KEYSTONE_URL = "http://%s:5000/v2.0" % OPENSTACK_HOST
OPENSTACK_KEYSTONE_DEFAULT_ROLE = "Member"
OPENSTACK_KEYSTONE_BACKEND = {
    'name': 'native',
    'can_edit_user': True,
    'can_edit_project': True
}
OPENSTACK_HYPERVISOR_FEATURES = {
    'can_set_mount_point': True,
    'can_encrypt_volumes': False
}
API_RESULT_LIMIT = 1000
API_RESULT_PAGE_SIZE = 20
TIME_ZONE = "UTC"
LOGGING = {
        'version': 1,
        'disable_existing_loggers': False,
        'handlers': {
            'null': {
                'level': 'DEBUG',
                'class': 'django.utils.log.NullHandler',
                },
            'console': {
                'level': 'INFO',
                'class': 'logging.StreamHandler',
                },
            },
        'loggers': {
            'django.db.backends': {
                'handlers': ['null'],
                'propagate': False,
                },
            'horizon': {
                'handlers': ['console'],
                'propagate': False,
            },
            'openstack_dashboard': {
                'handlers': ['console'],
                'propagate': False,
            },
            'novaclient': {
                'handlers': ['console'],
                'propagate': False,
            },
            'keystoneclient': {
                'handlers': ['console'],
                'propagate': False,
            },
            'glanceclient': {
                'handlers': ['console'],
                'propagate': False,
            },
            'nose.plugins.manager': {
                'handlers': ['console'],
                'propagate': False,
            }
        }
}

Revision history for this message

David Lyle (david-lyle) wrote on 2013-03-01:

I have encountered the same error. I can not reproduce it in the .venv environment. Our install process creates and uses debian packages and this is where we encountered the error. By editing the horizon/static/horizon/lib/jquery/jquery-ui-1.9.2.custom.min.js to change '(this.id="ui-id-"+ ++n)})' to '(this.id="ui-id-"+ (++n))})' will post patch shortly

David Lyle (david-lyle) on 2013-03-01

Changed in horizon:
assignee:	nobody → David Lyle (david-lyle)

David Lyle (david-lyle) on 2013-03-01

Changed in horizon:
status:	Incomplete → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-01: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23305

Changed in horizon:
status:	Confirmed → In Progress

Revision history for this message

David Lyle (david-lyle) wrote on 2013-03-04:

Ok, more digging... and the root cause of this error is the use of python-django-compressor-1.1.2 rather that python-django-compressor-1.2. There is a bug fix in version 1.2 that handles the '+ ++' syntax compression problem. The version posted to PyPi is 1.2 which is why this is not seen in development environment builds. There is no python-django-compressor default package for Precise and for Quantal and Raring the version is still 1.1.2. The nightly testing also only has 1.1.2 in the ppa: http://ppa.launchpad.net/openstack-ubuntu-testing/grizzly-trunk-testing/ubuntu/pool/main/p/python-django-compressor/

I can pull in a 1.2 package for a local mirror, but that doesn't solve the larger problem of installing on ubuntu of any flavor via .deb packages and no supported ppa to pull from.

So do we band-aid fix this in horizon? https://review.openstack.org/23305

Move the offending file out of the {% compress js %} tag

Upload a new .deb package to a supported ppa?

Gabriel Hurley (gabriel-hurley) on 2013-03-04

Changed in horizon:
milestone:	none → grizzly-rc1
importance:	Undecided → High

Revision history for this message

Gabriel Hurley (gabriel-hurley) wrote on 2013-03-05:

This bug is caused by an outdated version of django compressor in the ubuntu apt repo. It should not be fixed in Horizon master.

Changed in horizon:
importance:	High → Undecided
milestone:	grizzly-rc1 → none
status:	In Progress → Invalid

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-05:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in horizon (Ubuntu):
status:	New → Confirmed

James Page (james-page) on 2013-03-15

Changed in python-django-compressor (Ubuntu Raring):
assignee:	nobody → James Page (james-page)
Changed in horizon (Ubuntu Raring):
assignee:	nobody → James Page (james-page)

Revision history for this message

James Page (james-page) wrote on 2013-03-15:

OK _ I verified this is a distro issue with a new version of python-django-compressor; I'll get this uploaded to raring and backported to the trunk testing PPA and cloud archive for grizzly rc1.

Changed in horizon (Ubuntu Raring):
importance:	Undecided → High
Changed in python-django-compressor (Ubuntu Raring):
importance:	Undecided → High
status:	New → In Progress
Changed in horizon (Ubuntu Raring):
status:	Confirmed → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-15:

This bug was fixed in the package python-django-compressor - 1.2-0ubuntu1

---------------
python-django-compressor (1.2-0ubuntu1) raring; urgency=low

* New upstream release (LP: #1130610).
* d/watch: Fix watch file inline with upstream project name.
-- James Page <email address hidden> Fri, 15 Mar 2013 12:41:25 +0000

Changed in python-django-compressor (Ubuntu Raring):
status:	In Progress → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-20:

#10

This bug was fixed in the package horizon - 1:2013.1~rc1-0ubuntu1

---------------
horizon (1:2013.1~rc1-0ubuntu1) raring; urgency=low

  [ James Page ]
  * New upstream release candidate for Grizzly:
    - Recompress static JS and CSS and generate new manifest.json for
      offline compression.
  * d/watch: Update uversionmangle to deal with upstream versioning
    changes, remove tarballs.openstack.org.
  * d/control: Version python-compressor >= 1.2 (LP: #1130610).

  [ Adam Gandelman ]
  * debian/patches/ubuntu_local_settings.py: Refresh, specify memcache
    location as part of CACHES, as per upstream changes to example config.
-- James Page <email address hidden> Wed, 20 Mar 2013 11:20:17 +0000

Changed in horizon (Ubuntu Raring):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1155253

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.