SubDownloader

Renamed subtitle becomes lowercase

Bug #1126511 reported by Johan Godfried on 2013-02-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	SubDownloader	Fix Committed	Undecided	Unassigned

Bug Description

SubDownloader version: 2.0.18 (downloaded from Subdownloader website on 15-FEB-2013) / 2.0.18-1 (Fedora repository)
OS: Fedora 9 (downloaded) & Fedora 18 (Fedora repository)

When using the --rename-subs in CLI mode, the subtitle filename is based on the video filename but is converted to lowercase. After removing line 173 in FileManagement/Subtitle.py this problem is resolved and the case is kept the same as the video filename.

Line 173 in FileManagement/Subtitle.py is:
video_filename = video_filename.lower()

Tags:

Revision history for this message

Alessandro Losavio (alo21) wrote on 2013-02-18:

Thanks for your time on reporting this bug, making SubDownloader a better software (and Ubuntu too). I got the same bug, but unfortunately I can't find the same line that you sold. In fact in line 173 (last of the file), is 'return False', and ' video_filename = video_filename.lower()' is at line 156.

Are you sure about the fix. If yes, please upload as a patch a .py modified file. So I check it, and if all is OK, I will upload it.

Thanks again, and sorry for the delay.

Revision history for this message

Dajomas (dajomas) wrote on 2013-02-19:

Subtitle.py Edit (6.6 KiB, text/x-python)

Oops, my bad. The file has 173 lines. You are correct in your line assumption. The offending line is 156. I have attached the Subtitle.py file which works for me with line 156 commented out.

Revision history for this message

Alessandro Losavio (alo21) wrote on 2013-02-19:

Thanks for your patch, and for your time.The patch works well, so I am going to upload it as soon as possible. Your attention is appreciate.