indicator-cpufreq does not have icons when not using Ubuntu icon theme

The problem here is that indicator-cpufreq is not installing icons to the fallback theme so this would occur with any other theme that's not Ubuntu's. I've attached a patch that installs the ubuntu-mono-dark icons to hicolor (the fallback theme) as well.

I'm going to accept this a bit later as a temporary solution. What we really need is a "universal", probably coloured icons for hicolor.

Sorry to the comment 『no longer affects: indicator-cpufreq (Ubuntu)}』，I'm not intention to do that. But how to delete that comment?

 Compared indicator-cpufreq and indicator-messages, the icons should be in the "/usr/share/libindicator/icons/...", not "/usr/share/icons/...".

And here is the patch.

Z.X.Lyn, please don't mark the bug as «Fix Committed» until the patch is merged into trunk.

Now about your patch, 'cause you didn't answer my email: how does it fix this bug if it just installs the icons to another location (which is just another search path for the icons)? Did you actually build the package with your patch and tested it?

Hi, Artem Popov

1) I'm sorry for my recklessness.
2) I haven't received Email from you yet. Maybe mail system failed.
3) I did test it, by using bzr builddeb and I installed it without bug when I change icon theme to faenza or other icon themes.
    See my ppa https://launchpad.net/~newzxl/+archive/playground
4) Sorry. I have to learn how to merge and review.

Thanks.

Thanks for contributing, but I cannot accept your merge request in its current form:

1. There are 5641 lines (+5253/-0) 73 files modified in the diff. Obviously something went wrong in your local branch.
2. It doesn't really change the look of indicator-cpufreq when used with third-party icon themes. I just tested the current indicator-cpufreq deb from Raring and your PPA build against different Faenza variants and the applet looks identically with both.

To elaborate the 2nd point: the current version includes Cody's patch that installs the ubuntu-mono-dark icons to /usr/share/icons/hicolor (comment #1 to this bug). This actually works as a workaround providing the dark icons as fallback in all cases.

Your patch changes the hicolor install path to /usr/share/libindicator/icons/hicolor. But consider these points:

a) it doesn't touch dark and light icons
b) the current trunk has the fallback install path set to /usr/share/icons/hicolor and both paths are obviously in the icon search path on raring, which is the current target for development.
c) there is no specification or agreement for installation path of indicator icons. Current default indicators use /usr/share/libindicator/icons (indicator-sound, indicator-session) and /usr/share/icons (indicator-messages, indicator-printers, indicator-sync).

Note, that indicator-messages which you refer in comment #3 actually installs the icons to /usr/share/icons on Raring. But anyway, if you're interested to fix this bug I suggest you do the following:

1. Try building vanilla 0.2.2-0ubuntu1 on Precise. If it works without extra patches, it's ok. If it doesn't work and you need it on Precise for some reason - follow the SRU procedure (https://wiki.ubuntu.com/StableReleaseUpdates) to have your patch accepted downstream for Precise.
2. Do some research to resolve the above cases a) and c).
3. Fix point 1 above.

In other words, have a clean merge request ready supplied by a strong argument on why we should change the icon installation path (link to a spec, etc.) and I'll accept it. Cheers,

The patch in codygarver 's trunk is right, I tested it. I didn't test that fix before I try to debug because it was not fixed even in 12.10.
Sorry. I have to confess that I made a mistake and waste Artem's time.
This bug can be closed after new version of cpufreq being released.