Patches that fix build warnings need to be updated

Bug #1123510 reported by Tyler Hicks
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
audit (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

The patches that fix various build warnings should be updated now that they've
been merged upstream. Upstream made a code change to one of the patches
(https://www.redhat.com/archives/linux-audit/2013-February/msg00014.html) that
is reflected in the attached debdiff. I also added upstream SVN ids to all of
the patches now that they've been merged. The audit project's web interface is
out of date with the development tree, so I had to specific SVN id's rather
than URLs to the patches.

I've tested this debdiff on my local machine. auditd starts up and accepts
audit messages as expected. I also tested the reconfigure functionality
affected by the code change, which is done by sending auditd a SIGHUP to force
it to reconfigure itself. It handled the SIGHUP fine and audited that it was
successful:

type=DAEMON_CONFIG msg=audit(1360618841.877:6590) config changed, auid=0
pid=15094 subj=? res=success

Revision history for this message
Tyler Hicks (tyhicks) wrote :
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I'll take a look at this as part of my patch piloting, which I hope to do today.

Changed in audit (Ubuntu):
assignee: Jamie Strandboge (jdstrand) → nobody
status: Confirmed → In Progress
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for your patch. It is missing the LP bug reference, but other than that, it looks great. I built it locally and tested it and everything still runs fine. I've adjusted debian/changelog for the bug reference and am uploading now. ACK

Changed in audit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package audit - 1:2.2.2-1ubuntu4

---------------
audit (1:2.2.2-1ubuntu4) raring; urgency=low

  * debian/patches/fix-unused-result-warnings.patch: Adjust patch to reflect a
    change made by upstream. Don't treat nice() failures as fatal during an
    auditd reconfigure. (LP: #1123510)
  * debian/patches/fix-asprintf-warnings.patch,
    debian/patches/fix-unused-result-warnings.patch,
    debian/patches/fix-discards-const-qualifier-warnings.patch: Update patch
    tags with potential release version and SVN commit id to indicate that
    these patches were merged upstream.
 -- Tyler Hicks <email address hidden> Mon, 11 Feb 2013 13:25:46 -0800

Changed in audit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.