[SRU] nova does not set container_format when snapshotting instance with ref image deleted

Bug #1119248 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova (Ubuntu)
Fix Released
Undecided
Chuck Short

Bug Description

This bug affects release: 12.04 LTS Precise

Affected package: https://launchpad.net/ubuntu/precise/+source/nova/2012.1.3+stable-20120827-4d2a4afe-0ubuntu1.1

Precise currenlty runs Openstack Essex.

A fix for this bug was added to Openstack Folsom and backported to Essex but 12.04 does not yet include this fix so we are patching the current release to include this fix.

[Impact]

 * User has images stuck in "Queued" status in Glance. This is cuased by created snapshots of instances that have had their base image deleted. The user is using Essex.

 * The bug has been fixed in Folsom

 * The fix ensures that the container_format field is always set to a legitimate value i.e. at least 'bare', since Glance expects it to be set to non-None/NULL.

[Test Case]

  This issue can be easily reproduced with the following steps:

    1. Add image 'image1' to glance
    2. Create VM 'vm1' using 'image1'
    3. Create snapshot 'snap1' of 'vm1'
    4. Create VM 'vm2' from 'snap1'
    5. Delete snapshot image 'snap1'
    6. Create snapshot 'snap2' of 'vm2'

   If you do 'nova image-list' you will see the image for 'snap2' is stuck in the SAVING state (which translates to 'QUEUED' in Glance). If you then go to Glance server and look in the glance/registry.log you will see that the image update failed becauise the container_format is not set.

[Regression Potential]

 * not likely.

Revision history for this message
Edward Hope-Morley (hopem) wrote :
description: updated
summary: - Precise - Openstack/Glance - image snapshots do not become active for
- one tenant in nova
+ [SRU] Precise - Openstack/Glance - image snapshots do not become active
+ for one tenant in nova
summary: - [SRU] Precise - Openstack/Glance - image snapshots do not become active
- for one tenant in nova
+ [SRU] nova does not set container_format when snapshotting instance with
+ ref image deleted
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for your work on this! debian/changelog has a version of 2012.1.4+stable-20121217-9f277e38-0ubuntu2 against precise-proposed, but this version is not in the archive. Your patch should be against 2012.1.3+stable-20120827-4d2a4afe-0ubuntu1.1 (what is currently in precise-security/precise-updates).

Otherwise the patch looks fine. Can you adjust this and mention your testing results after patching 2012.1.3+stable-20120827-4d2a4afe-0ubuntu1.1?

Thanks!

Changed in nova (Ubuntu):
status: New → Incomplete
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Discussed this on IRC. A debdiff/merge request will be prepared against precise-updates in the coming days. Unsubscribing ubuntu-sponsors for now.

Changed in nova (Ubuntu):
status: Incomplete → Triaged
Revision history for this message
Edward Hope-Morley (hopem) wrote :

A new branch has been created with a patch on top of precise-updates as discussed:

https://code.launchpad.net/~hopem/nova/precise-updates-sru-lp1119248/+merge/148663

Re-subscribing ubuntu-sponsors

Revision history for this message
Edward Hope-Morley (hopem) wrote :

The following merge request has been approved.

https://code.launchpad.net/~hopem/nova/precise-updates-sru-lp1119248/+merge/148663

This has been tested on Precise Essex.

Closing this bug.

Changed in nova (Ubuntu):
assignee: nobody → Edward Hope-Morley (hopem)
status: Triaged → Fix Committed
Changed in nova (Ubuntu):
status: Fix Committed → In Progress
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Ok not closing ths just yet. Needs merge approver to review before closing.

Changed in nova (Ubuntu):
assignee: Edward Hope-Morley (hopem) → nobody
Revision history for this message
Iain Lane (laney) wrote :

I think zul is handling this, so I'll remove the Ubuntu sponsors

Changed in nova (Ubuntu):
assignee: nobody → Chuck Short (zulcss)
Chris J Arges (arges)
tags: added: cts-cloud-review
Changed in nova (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.