Checkbox

multi-head test not run on desktop because dmi.product test failed

Bug #1116681 reported by Jeff Lane  on 2013-02-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Checkbox	Fix Released	High	Jeff Lane 

Bug Description

For the actual result:
https://certification.canonical.com/hardware/201302-12676/submission/i0ryyDGuuBim19Y/result/test:monitor%252Fmulti-head:__monitor__

This test has the constraint: dmi.product not in ['Notebook','Laptop','Portable']

It appears that this is not working correctly. DMI clearly shows the system to be a "Desktop" chassis type:
Handle 0x0003, DMI type 3, 22 bytes
Chassis Information
Manufacturer: Gigabyte Technology Co., Ltd.
Type: Desktop
Lock: Not Present
Version: To Be Filled By O.E.M.
Serial Number: To Be Filled By O.E.M.
Asset Tag: To Be Filled By O.E.M.
Boot-up State: Safe
Power Supply State: Safe
Thermal State: Safe
Security Status: None
OEM Information: 0x00000000
Height: Unspecified
Number Of Power Cords: 1
Contained Elements: 0
SKU Number: To be filled by O.E.M.

so perhaps something is broken with the dmi interpreter (dmi.py) or the bits that interpret the requires are not honoring the python statement.

Related branches

lp:~bladernr/checkbox/1116681-fix-multi-head-description

Merged into lp:checkbox at revision 2103

Zygmunt Krynicki (community): Approve on 2013-05-03

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-02-05:

You can check quickly with something like:

sudo /usr/share/checkbox/scripts/dmi_resource |grep -i product

If you like, attach the complete output of

sudo /usr/share/checkbox/scripts/dmi_resource

so we can try to see why this is failing.

Changed in checkbox:
status:	New → Incomplete

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-02-06:

Probably won't happen as this is not a system we have access to :( and probably wont get the OEM to do anything for us.

I was hoping this could be tested in one of the labs on a desktop.

Changed in checkbox:
status:	Incomplete → New

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-02-07:

dmidecode Edit (1023 bytes, text/plain)

OK, Greg was kind enough to let me access a system on the Lexington lab, here are all the product entries from dmi_resource:

product: X01
product: Studio XPS 8000
product: 0T568R
product: Desktop
product: Genuine Intel(R) CPU 000 @ 2.53GHz

I'm attaching the complete dmi_resource output.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-02-07:

Here's a link to the submission on c4. https://certification.canonical.com/hardware/201302-12676/submission/4060/test-results/?page=5

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-02-07: Re: [Bug 1116681] Re: multi-head test not run on desktop because dmi.product test failed

On 02/07/2013 12:54 PM, Daniel Manrique wrote:
> Here's a link to the submission on c4.
> https://certification.canonical.com/hardware/201302-12676/submission/4060
> /test-results/?page=5
>
Looks like it skipped the test there too...
monitor/multi-head test unsupported Job requirement not met:
'dmi.product not in ['Notebook','Laptop','Portable']'

--
Jeff Lane - Hardware Certification Engineer and Test Tools Developer
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-02-08:

OK, I was able to reproduce this problem on my sole desktop system. One interesting thing I notice is that the requires: for this job are unique: it's the ONLY instance in all checkbox jobs where a requirement is expressed as "<something> not in [list]". So there may be some weirdness in the requirements evaluator that causes this particular scenario to fail. Now, to put a few wires in resource_info to measure what happens in this case...

Brendan Donegan (brendan-donegan) on 2013-05-02

Changed in checkbox:
status:	New → Confirmed
importance:	Undecided → High

Jeff Lane  (bladernr) on 2013-05-03

Changed in checkbox:
status:	Confirmed → Triaged
assignee:	nobody → Jeff Lane (bladernr)
status:	Triaged → In Progress

Jeff Lane  (bladernr) on 2013-05-03

Changed in checkbox:
status:	In Progress → Fix Committed

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-05-03:

OK, this bug is specifically about the multi-head test, not checkbox parsing requirements. So to fix THIS bug, I've changed the requires for the multi-head test to use syntax we know works:

dmi.product in [LIST]

instead of what it was:

dmi.product not in [list]

and I set LIST to be what seem to be the for possible DMI types for desktop systems.

I've also opened another bug to address the parsing option. (bug #1176189)

Brendan Donegan (brendan-donegan) on 2013-05-15